Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751996AbbHJLmb (ORCPT ); Mon, 10 Aug 2015 07:42:31 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:33245 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbbHJLma (ORCPT ); Mon, 10 Aug 2015 07:42:30 -0400 Date: Mon, 10 Aug 2015 12:42:24 +0100 From: Lee Jones To: Henry Chen Cc: Samuel Ortiz , Matthias Brugger , Sascha Hauer , Flora Fu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] mfd: mt6397: Implement wake handler and suspend/resume for mt6397-core.c Message-ID: <20150810114224.GD3249@x1> References: <1438268846-22451-1-git-send-email-henryc.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1438268846-22451-1-git-send-email-henryc.chen@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1586 Lines: 42 No need to mention the filename in the subject line. You already mentioned which driver is effected by the change. > Register mt6393_irq as wake up source to pinctrl by flag "IRQF_NO_SUSPEND". > Implement .irq_set_wake() function of pmic to keep who is wakeup source, > and enable irq on .suspend()and restore irq on .resume(). > > Signed-off-by: Henry Chen > --- > drivers/mfd/mt6397-core.c | 49 ++++++++++++++++++++++++++++++++++++++++- > include/linux/mfd/mt6397/core.h | 1 + > 2 files changed, 49 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 03929a6..aebdee5 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c [...] > @@ -142,6 +161,7 @@ static int mt6397_irq_domain_map(struct irq_domain *d, unsigned int irq, > irq_set_chip_data(irq, mt6397); > irq_set_chip_and_handler(irq, &mt6397_irq_chip, handle_level_irq); > irq_set_nested_thread(irq, 1); > + Remainder of the patch looks okay, but this irrelevant change, which has nothing to do with the remainder of the patch will cause issues if I attempt to apply it. Please remove and re-submit. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/