Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbbHJLnF (ORCPT ); Mon, 10 Aug 2015 07:43:05 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:51332 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbbHJLnB (ORCPT ); Mon, 10 Aug 2015 07:43:01 -0400 Date: Mon, 10 Aug 2015 13:42:56 +0200 From: Peter Zijlstra To: Jiri Olsa Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com, luto@kernel.org, torvalds@linux-foundation.org, kan.liang@intel.com, mingo@kernel.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/core] perf/x86: Add an MSR PMU driver Message-ID: <20150810114256.GZ16853@twins.programming.kicks-ass.net> References: <1437407346-31186-1-git-send-email-kan.liang@intel.com> <20150810111936.GC31841@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150810111936.GC31841@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 40 On Mon, Aug 10, 2015 at 01:19:36PM +0200, Jiri Olsa wrote: > On Tue, Aug 04, 2015 at 02:01:20AM -0700, tip-bot for Andy Lutomirski wrote: > > SNIP > > > + /* unsupported modes and filters */ > > + if (event->attr.exclude_user || > > + event->attr.exclude_kernel || > > + event->attr.exclude_hv || > > + event->attr.exclude_idle || > > + event->attr.exclude_host || > > + event->attr.exclude_guest || > > + event->attr.sample_period) /* no sampling */ > > + return -EINVAL; > > + > > + event->hw.idx = -1; > > + event->hw.event_base = msr[cfg].msr; > > + event->hw.config = cfg; > > + > > + return 0; > > +} > > + > > +static inline u64 msr_read_counter(struct perf_event *event) > > +{ > > + u64 now; > > + > > + if (event->hw.event_base) > > + rdmsrl(event->hw.event_base, now); > > + else > > + now = rdtsc(); > > not sure itf there's newer version, but I needed attached change > to make it compile on latest Arnaldo's tree You need tip/x86/asm merged in. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/