Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753954AbbHJMBW (ORCPT ); Mon, 10 Aug 2015 08:01:22 -0400 Received: from mdfmta010.mxout.tbr.inty.net ([91.221.168.51]:59209 "EHLO smtp.demon.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751553AbbHJMBT (ORCPT ); Mon, 10 Aug 2015 08:01:19 -0400 X-Greylist: delayed 305 seconds by postgrey-1.27 at vger.kernel.org; Mon, 10 Aug 2015 08:01:18 EDT Message-ID: <55C8906F.2040507@rns-stearn.demon.co.uk> Date: Mon, 10 Aug 2015 12:52:15 +0100 From: Richard Stearn Organization: Someday User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: Ben Hutchings CC: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Ralf Baechle , "David S. Miller" Subject: Re: [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect. References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MDF-HostID: 3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1308 Lines: 44 Ben Hutchings wrote: > 3.2.71-rc1 review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Richard Stearn > > commit da278622bf04f8ddb14519a2b8214e108ef26101 upstream. > > This may result in a kernel panic. The bug has always existed but > somehow we've run out of luck now and it bites. > > Signed-off-by: Richard Stearn > Signed-off-by: Ralf Baechle > Signed-off-by: David S. Miller > Signed-off-by: Ben Hutchings > --- > net/ax25/ax25_subr.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/net/ax25/ax25_subr.c > +++ b/net/ax25/ax25_subr.c > @@ -265,6 +265,7 @@ void ax25_disconnect(ax25_cb *ax25, int > { > ax25_clear_queues(ax25); > > + ax25_stop_heartbeat(ax25); > ax25_stop_t1timer(ax25); > ax25_stop_t2timer(ax25); > ax25_stop_t3timer(ax25); This patch should _not_ be applied. Breaks other parts of the driver. Investigations on-going. -- Regards Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/