Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907AbbHJMAT (ORCPT ); Mon, 10 Aug 2015 08:00:19 -0400 Received: from mail-wi0-f196.google.com ([209.85.212.196]:33427 "EHLO mail-wi0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771AbbHJMAH (ORCPT ); Mon, 10 Aug 2015 08:00:07 -0400 MIME-Version: 1.0 In-Reply-To: <87mvxzptqv.fsf@linux.vnet.ibm.com> References: <1437756119-12817-1-git-send-email-a.ryabinin@samsung.com> <1437756119-12817-3-git-send-email-a.ryabinin@samsung.com> <87mvxzptqv.fsf@linux.vnet.ibm.com> Date: Mon, 10 Aug 2015 15:00:05 +0300 Message-ID: Subject: Re: [PATCH v4 2/7] mm: kasan: introduce generic kasan_populate_zero_shadow() From: Andrey Ryabinin To: "Aneesh Kumar K.V" Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Linus Walleij , David Keitel , Alexander Potapenko , Andrew Morton , Dmitry Vyukov , "linux-mm@kvack.org" , LKML , Alexey Klimov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2088 Lines: 53 2015-08-10 9:01 GMT+03:00 Aneesh Kumar K.V : > Andrey Ryabinin writes: > >> Introduce generic kasan_populate_zero_shadow(start, end). >> This function maps kasan_zero_page to the [start, end] addresses. >> >> In follow on patches it will be used for ARMv8 (and maybe other >> architectures) and will replace x86_64 specific populate_zero_shadow(). >> >> Signed-off-by: Andrey Ryabinin > > This assume that we can have shared pgtable_t in generic code ? Is that > true for generic code ? Even if it is we may want to allow some arch to > override this ? On ppc64, we store the hardware hash page table slot > number in pte_t, Hence we won't be able to share pgtable_t. > So, ppc64 could define some config which will disable compilation of mm/kasan/kasan_init.c. However, it might be a bad idea to use such never defined config symbol now. So I think this could be done later, in "KASAN for powerpc" series. > > >> --- >> arch/x86/mm/kasan_init_64.c | 14 ---- >> include/linux/kasan.h | 8 +++ >> mm/kasan/Makefile | 2 +- >> mm/kasan/kasan_init.c | 151 ++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 160 insertions(+), 15 deletions(-) >> create mode 100644 mm/kasan/kasan_init.c >> >> diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c >> index e1840f3..812086c 100644 >> --- a/arch/x86/mm/kasan_init_64.c >> +++ b/arch/x86/mm/kasan_init_64.c >> @@ -12,20 +12,6 @@ >> extern pgd_t early_level4_pgt[PTRS_PER_PGD]; >> extern struct range pfn_mapped[E820_X_MAX]; >> >> -static pud_t kasan_zero_pud[PTRS_PER_PUD] __page_aligned_bss; >> -static pmd_t kasan_zero_pmd[PTRS_PER_PMD] __page_aligned_bss; >> -static pte_t kasan_zero_pte[PTRS_PER_PTE] __page_aligned_bss; >> - >> -/* > > -aneesh > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/