Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbbHJM3F (ORCPT ); Mon, 10 Aug 2015 08:29:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:46529 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbbHJM3B (ORCPT ); Mon, 10 Aug 2015 08:29:01 -0400 From: Thomas Renninger To: "Shreyas B. Prabhu" Cc: rjw@rjwysocki.net, pavsubra@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] cpupower tools: Fix error when running cpupower monitor Date: Mon, 10 Aug 2015 14:28:59 +0200 Message-ID: <9534146.fFc3TD2C5D@skinner> User-Agent: KMail/4.14.9 (Linux/3.16.7-21-desktop; KDE/4.14.9; x86_64; ; ) In-Reply-To: <1438582560-13352-1-git-send-email-shreyas@linux.vnet.ibm.com> References: <1438582560-13352-1-git-send-email-shreyas@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1645 Lines: 45 On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote: > get_cpu_topology() tries to get topology info from all cpus by reading > files in the topology sysfs dir. If a cpu is offlined, since it doesn't > have topology dir, this function fails and returns -1. This causes > functions relying on get_cpu_topology() to fail. For example- > > $ cpupower monitor > Cannot read number of available processors > > Fix this by skipping fetching topology info for offline cpus. Looks fine. Thanks! Acked-by: Thomas Renninger > > Signed-off-by: Shreyas B. Prabhu > Reported-by: Pavaman Subramaniyam > --- > tools/power/cpupower/utils/helpers/topology.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/power/cpupower/utils/helpers/topology.c > b/tools/power/cpupower/utils/helpers/topology.c index > c13120af519b..cea398c176e7 100644 > --- a/tools/power/cpupower/utils/helpers/topology.c > +++ b/tools/power/cpupower/utils/helpers/topology.c > @@ -73,6 +73,8 @@ int get_cpu_topology(struct cpupower_topology *cpu_top) > for (cpu = 0; cpu < cpus; cpu++) { > cpu_top->core_info[cpu].cpu = cpu; > cpu_top->core_info[cpu].is_online = sysfs_is_cpu_online(cpu); > + if (!cpu_top->core_info[cpu].is_online) > + continue; > if(sysfs_topology_read_file( > cpu, > "physical_package_id", -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/