Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751950AbbHJMix (ORCPT ); Mon, 10 Aug 2015 08:38:53 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33564 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751645AbbHJMiv (ORCPT ); Mon, 10 Aug 2015 08:38:51 -0400 Date: Mon, 10 Aug 2015 14:38:01 +0200 From: Thierry Reding To: Srinivas Kandagatla Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com, David Airlie , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties. Message-ID: <20150810123800.GB1262@ulmo.nvidia.com> References: <1439207923-30812-1-git-send-email-srinivas.kandagatla@linaro.org> <1439207974-30902-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S96ff6o5osL9bGCL" Content-Disposition: inline In-Reply-To: <1439207974-30902-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2259 Lines: 59 --S96ff6o5osL9bGCL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2015 at 12:59:34PM +0100, Srinivas Kandagatla wrote: > This patch modifies the driver to support standard gpio properties along > with deprecated properties. This will help us upstream and cleanup the > non-standard properties over the time. >=20 > Signed-off-by: Srinivas Kandagatla > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 35 +++++++++++++++++++++++++---------- > 1 file changed, 25 insertions(+), 10 deletions(-) >=20 > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/h= dmi.c > index 8145362..e918889 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -339,19 +339,34 @@ static const struct of_device_id dt_match[] =3D { > }; > =20 > #ifdef CONFIG_OF > +/* This code will be removed once we move to gpiod based calls */ Why don't you do this now instead of duplicating what is essentially already implemented in gpiolib? Thierry --S96ff6o5osL9bGCL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyJsoAAoJEN0jrNd/PrOhcVIP+wc6dAX+uwf8xsDJydu3sx1r HezygLa/9Ha7ly30RT42b+28Digm3lCf/lZ5Sq+Ofyh+TloXM0S9XCDJDTJeD8hC QbgVJroUcr9+nHVrUcLuESSyzIJEDlhlwC/jUctgubl+4u4om4tBR1I8F/I5rX9P VsDD0NgXjNj6JF1/fAWFC6WVV5kEKPtZz/rP9NvlCyx3XaovTpZmf4s0Zq7Dsale L2+RMugiOpozGkR60GzcosKt1mhnOTO4NdMRPCa5YTaBTCwt6//kpaQtfMA2Hg59 KVKBGehXhgHqGKByRNx4ozPmA4MUijFGTZkzXUdP/6AYpA2amBDYa/Xz7wjLBSxC 6ztWh19l54/5Ch6bnDUcdbBv0aZ6WoJanv4shiqf2J5b2ac59g8K9wnEevQnMOvj 04iOKTUFU2rqNuP51LgNgCMed1IwaNvfdc5kmcpDqO8cGj5MzZihmnXqprI6F3d0 bs7EHyhU+rvI2t+fSwxRyAZxufkuusEdgxmsyw4uqZmK+N3GbZ6wKFPlg9frrK2C yqIJBDePkU4XCjg5DdIkXOpwFSaAOzzhhZUq/hE5OLFTUDaVxVNe2vMlgVLiOe/M 3WRNOrfIo917PHYQ7gPZ4lZDEkqBbb7qJm4Tnr64g3CyJJk59kARFVmQezCqn/Vq xcGz6bf+BqW1xo25wfDF =Adei -----END PGP SIGNATURE----- --S96ff6o5osL9bGCL-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/