Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbbHJMlT (ORCPT ); Mon, 10 Aug 2015 08:41:19 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:46218 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbbHJMlR (ORCPT ); Mon, 10 Aug 2015 08:41:17 -0400 X-IronPort-AV: E=Sophos;i="5.15,645,1432598400"; d="scan'208";a="292955029" Message-ID: <55C89BE9.4040806@citrix.com> Date: Mon, 10 Aug 2015 13:41:13 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Julien Grall , Stefano Stabellini CC: , , David Vrabel , , Boris Ostrovsky , Subject: Re: [Xen-devel] [PATCH v3 09/20] xen/biomerge: Don't allow biovec to be merge when Linux is not using 4KB page References: <1438966019-19322-1-git-send-email-julien.grall@citrix.com> <1438966019-19322-10-git-send-email-julien.grall@citrix.com> <55C889E4.8050307@citrix.com> <55C88BD8.7040807@citrix.com> In-Reply-To: <55C88BD8.7040807@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 20 On 10/08/15 12:32, Julien Grall wrote: > On 10/08/15 12:25, Stefano Stabellini wrote: >> yes and page/pages: >> >> xen/biomerge: Don't allow biovec's to be merged when Linux is not using 4KB pages > > Why the ' in biovec's ? Shouldn't we says biovecs directly? Pluralizing named C structures with apostrophes is valid. It makes it clear we're talking about "struct biovec" and not "struct biovecs" objects. You could also consider "biovec's" to be a contraction for "biovec objects" so the apostrophe is "correct". David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/