Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbbHJMqI (ORCPT ); Mon, 10 Aug 2015 08:46:08 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33498 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbbHJMqD (ORCPT ); Mon, 10 Aug 2015 08:46:03 -0400 Date: Mon, 10 Aug 2015 14:45:12 +0200 From: Thierry Reding To: Srinivas Kandagatla Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com, David Airlie , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties. Message-ID: <20150810124510.GC1262@ulmo.nvidia.com> References: <1439207923-30812-1-git-send-email-srinivas.kandagatla@linaro.org> <1439207962-30860-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CPaaJmjEtnx7DmsZ" Content-Disposition: inline In-Reply-To: <1439207962-30860-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4025 Lines: 102 --CPaaJmjEtnx7DmsZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2015 at 12:59:22PM +0100, Srinivas Kandagatla wrote: > This patch updates the bindings to discourage the usage of non standard > gpio properites, this will help in projects focused on upstreaming. That last part is an odd comment to make in the commit message of a patch submitted upstream... > These deprecated properties are still supported but will be remove over > the time. You can't ever remove them because you can't ever be sure that people won't be using an old DTB. >=20 > Signed-off-by: Srinivas Kandagatla > --- > Documentation/devicetree/bindings/drm/msm/hdmi.txt | 22 ++++++++++++++++= +----- > 1 file changed, 17 insertions(+), 5 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/drm/msm/hdmi.txt b/Documen= tation/devicetree/bindings/drm/msm/hdmi.txt > index c43aa53..acba581 100644 > --- a/Documentation/devicetree/bindings/drm/msm/hdmi.txt > +++ b/Documentation/devicetree/bindings/drm/msm/hdmi.txt > @@ -11,15 +11,27 @@ Required properties: > - interrupts: The interrupt signal from the hdmi block. > - clocks: device clocks > See ../clocks/clock-bindings.txt for details. > -- qcom,hdmi-tx-ddc-clk-gpio: ddc clk pin > -- qcom,hdmi-tx-ddc-data-gpio: ddc data pin > -- qcom,hdmi-tx-hpd-gpio: hpd pin > +- qcom,hdmi-tx-ddc-clk-gpios: ddc clk pin > +- qcom,hdmi-tx-ddc-data-gpios: ddc data pin > +- qcom,hdmi-tx-hpd-gpios: hpd pin > - core-vdda-supply: phandle to supply regulator > - hdmi-mux-supply: phandle to mux regulator > =20 > +- qcom,hdmi-tx-ddc-clk-gpio: (deprecated) use > + "qcom,hdmi-tx-ddc-clk-gpios" instead > +- qcom,hdmi-tx-ddc-data-gpio: (deprecated) use > + "qcom,hdmi-tx-ddc-data-gpios" instead > +- qcom,hdmi-tx-hpd-gpio: (deprecated) use > + "qcom,hdmi-tx-hpd-gpios" instead > + > Optional properties: > -- qcom,hdmi-tx-mux-en-gpio: hdmi mux enable pin > -- qcom,hdmi-tx-mux-sel-gpio: hdmi mux select pin > +- qcom,hdmi-tx-mux-en-gpios: hdmi mux enable pin > +- qcom,hdmi-tx-mux-sel-gpios: hdmi mux select pin > + > +- qcom,hdmi-tx-mux-en-gpio: (deprecated) use "qcom,hdmi-tx-mux-en-gpios" > + instead > +- qcom,hdmi-tx-mux-sel-gpio: (deprecated) use "qcom,hdmi-tx-mux-sel-gpio" > + instead > - pinctrl-names: the pin control state names; should contain "default" > - pinctrl-0: the default pinctrl state (active) > - pinctrl-1: the "sleep" pinctrl state I don't see much use in listing that these properties are deprecated. We already have code to catch the deprecated names, so having them in the binding will at best be distracting. Anyway, I don't know if there's been any advice on this from the device tree bindings maintainers, so adding devicetree@vger.kernel.org for visibility. Thierry --CPaaJmjEtnx7DmsZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyJzWAAoJEN0jrNd/PrOhfQYP/RJSxc5vZG+yNNYIrlMBbayw PdTlIgy+LcWEfGvUD92PuHXxHQY9d2QiHCInVHgkrSGzhSNblCKtGy7Z/Jfm05Jn QTTtGQdeoN6LbLihKFSeT8AAUKeZyDSxk1yvj4w4N4s6JKxo72eMxyxRYeWdBdJU akjbjUxIl+UxurE94JwzLLXlVnO7+2MSFZ78/OQWaItxYG85MObmLwiNwxhAgasK NAzIjHRqsEiEIc599DfkJs+uGIVrC4cysne4w6sSfckF9539v8TSVTWzw242t62C yfGtKYkrt7202sZdZO1w67l/P5HHXI1R0qqrPLolsWJnSjByFFyyIc8f+r/pBHH4 Y2bKFYmhF+fWgHZ4KMuTIDG5O4rAO/TCWQJoRQtpQbFP/qnQOfsPaFLDQGE37K0n M5JXgGNcLEGyV1huN5dWAJ2L4yAlFpYlwUr7FZPetfXiCIL100uVMKIMj5qNESGk Tmsorbtpy+cqQM5reAt2242EVL4aMdVIIH7rmupoIdtQnV0L6zyU5uvu0HJtRA2E LHInqFcQxxw8/IYh1xp80weLrcuAoIroGKTJoYkVkWjiFNv61rBFHrY/W8RkNvC4 ft8nbR+ufnbd7DRhJDy8EBmAIEXvIxrtePG5mG8VUAZ5K5mbgawak+PiNCoQ5QAg GbjOQ+AFlKcRF16DKs2E =tkdq -----END PGP SIGNATURE----- --CPaaJmjEtnx7DmsZ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/