Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753813AbbHJNP0 (ORCPT ); Mon, 10 Aug 2015 09:15:26 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34880 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbbHJNPV (ORCPT ); Mon, 10 Aug 2015 09:15:21 -0400 Message-ID: <55C8A3E6.40305@linaro.org> Date: Mon, 10 Aug 2015 14:15:18 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thierry Reding CC: dri-devel@lists.freedesktop.org, robdclark@gmail.com, David Airlie , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties. References: <1439207923-30812-1-git-send-email-srinivas.kandagatla@linaro.org> <1439207974-30902-1-git-send-email-srinivas.kandagatla@linaro.org> <20150810123800.GB1262@ulmo.nvidia.com> In-Reply-To: <20150810123800.GB1262@ulmo.nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1660 Lines: 43 On 10/08/15 13:38, Thierry Reding wrote: > On Mon, Aug 10, 2015 at 12:59:34PM +0100, Srinivas Kandagatla wrote: >> This patch modifies the driver to support standard gpio properties along >> with deprecated properties. This will help us upstream and cleanup the >> non-standard properties over the time. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/gpu/drm/msm/hdmi/hdmi.c | 35 +++++++++++++++++++++++++---------- >> 1 file changed, 25 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c >> index 8145362..e918889 100644 >> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c >> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c >> @@ -339,19 +339,34 @@ static const struct of_device_id dt_match[] = { >> }; >> >> #ifdef CONFIG_OF >> +/* This code will be removed once we move to gpiod based calls */ > > Why don't you do this now instead of duplicating what is essentially > already implemented in gpiolib? > One of the thing that Rob asked in his comments (http://www.spinics.net/lists/arm-kernel/msg437675.html) was to retain the support for old devices, moving to gpiod ATM would break such devices as they are still using legacy gpiolib and its naming. If Rob is ok to drop gpio properties which does not have "-gpio" or "-gpios" suffix then we can get rid of this function all together. --srini > Thierry > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/