Date: Mon, 10 Aug 2015 15:26:42 +0200
From: Thierry Reding <thierry.reding@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio
 properties.
Message-ID: <20150810132640.GB7302@ulmo.nvidia.com>
References: <1439207923-30812-1-git-send-email-srinivas.kandagatla@linaro.org>
 <1439207974-30902-1-git-send-email-srinivas.kandagatla@linaro.org>
 <20150810123800.GB1262@ulmo.nvidia.com>
 <55C8A3E6.40305@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="U+BazGySraz5kW0T"
Content-Disposition: inline
In-Reply-To: <55C8A3E6.40305@linaro.org>
User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2995
Lines: 78


--U+BazGySraz5kW0T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 10, 2015 at 02:15:18PM +0100, Srinivas Kandagatla wrote:
>=20
>=20
> On 10/08/15 13:38, Thierry Reding wrote:
> >On Mon, Aug 10, 2015 at 12:59:34PM +0100, Srinivas Kandagatla wrote:
> >>This patch modifies the driver to support standard gpio properties along
> >>with deprecated properties. This will help us upstream and cleanup the
> >>non-standard properties over the time.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>---
> >>  drivers/gpu/drm/msm/hdmi/hdmi.c | 35 +++++++++++++++++++++++++-------=
---
> >>  1 file changed, 25 insertions(+), 10 deletions(-)
> >>
> >>diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi=
/hdmi.c
> >>index 8145362..e918889 100644
> >>--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> >>+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> >>@@ -339,19 +339,34 @@ static const struct of_device_id dt_match[] =3D {
> >>  };
> >>
> >>  #ifdef CONFIG_OF
> >>+/* This code will be removed once we move to gpiod based calls */
> >
> >Why don't you do this now instead of duplicating what is essentially
> >already implemented in gpiolib?
> >
> One of the thing that Rob asked in his comments
> (http://www.spinics.net/lists/arm-kernel/msg437675.html) was to retain the
> support for old devices, moving to gpiod ATM would break such devices as
> they are still using legacy gpiolib and its naming.
>=20
>=20
> If Rob is ok to drop gpio properties which does not have "-gpio" or "-gpi=
os"
> suffix then we can get rid of this function all together.

If you make the switch to gpiod_*() APIs you'll get this for free.
There's really no need for having a duplicate of what gpiod_get()
already does for you.

Thierry

--U+BazGySraz5kW0T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJVyKaQAAoJEN0jrNd/PrOhv2oQAKS7tq3cxXsqHSjaL36TQAGE
0mPtmy8hNsfyS6FHhcgccd8Qen9YJQ2div/1yfPP2YUukZaMQVI7lUS0E0nb94ep
nwFMMcr+8ma5MLhhPTxNtJUe+xAHBlKRbcp0IQjaV11cXV+putc7Ad+0/3oTcBJg
7NqK4Hdk8DcGqZFchvoQHAKotgRbXn5w/eGxTVsk/zqXMhXKnTAaN08ahHRn/QDJ
FSwbtBVeRLLQg0N8CnHOX54yE+vBWpfRXCQ16iQ/u+LX1s2dW+Ksds5pliGbuZP/
I3/s8mMh4gnZpcO01jfv59zYRZ+6j1vkgUagUCwuL7hDOaq3ppb+h3G+ptqv9+Ts
WT4s9gSI8Mjav2+IgU6G5Mqo7Mw4sbMmIFM0Yb1C1RKSaHe87P2AIWvET3LGtDW6
w57WYcQOwjl2C+Dq/fL5avK2dNcy2MMGfhtGhxPFidvqqDzf2I5fUq5+Cxrf9i54
iAga5cnvWkM2vE+x8QXb2XSrU1N+3aRwEBGfAndads2cQnpexYEJof3rO9UMG2oA
Tq4A50gU2tsFm8cznxHHr5ro0VCPFVbjmc4bZOycynuG9FyKFY+B9GFRlr67GilD
PqMMtJL3Sx6gboxiuxin3+0jm7xYfJ6AKswX1XWwRjt7fChh4+eKCIfkn6CHKhbO
MIOr1F2nceJ5v1rFy8AT
=5MmY
-----END PGP SIGNATURE-----

--U+BazGySraz5kW0T--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/