Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754416AbbHJNeo (ORCPT ); Mon, 10 Aug 2015 09:34:44 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:34625 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192AbbHJNel (ORCPT ); Mon, 10 Aug 2015 09:34:41 -0400 Date: Mon, 10 Aug 2015 15:33:51 +0200 From: Thierry Reding To: Srinivas Kandagatla Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com, David Airlie , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Message-ID: <20150810133350.GC7302@ulmo.nvidia.com> References: <1439207923-30812-1-git-send-email-srinivas.kandagatla@linaro.org> <1439207989-30986-1-git-send-email-srinivas.kandagatla@linaro.org> <20150810124947.GD1262@ulmo.nvidia.com> <55C8A497.9050600@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Md/poaVZ8hnGTzuv" Content-Disposition: inline In-Reply-To: <55C8A497.9050600@linaro.org> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3874 Lines: 103 --Md/poaVZ8hnGTzuv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2015 at 02:18:15PM +0100, Srinivas Kandagatla wrote: >=20 >=20 > On 10/08/15 13:49, Thierry Reding wrote: > >On Mon, Aug 10, 2015 at 12:59:49PM +0100, Srinivas Kandagatla wrote: > >>This patch updates the bindings to discourage the usage of non standard > >>clock names, this will help in projects focused on upstreaming. > >> > >>These deprecated properties are still supported but will be remove over > >>the time. > >> > >>Signed-off-by: Srinivas Kandagatla > >>--- > >> Documentation/devicetree/bindings/drm/msm/hdmi.txt | 16 ++++++++-----= --- > >> 1 file changed, 8 insertions(+), 8 deletions(-) > >> > >>diff --git a/Documentation/devicetree/bindings/drm/msm/hdmi.txt b/Docum= entation/devicetree/bindings/drm/msm/hdmi.txt > >>index 6dc202e..6fbfdd8 100644 > >>--- a/Documentation/devicetree/bindings/drm/msm/hdmi.txt > >>+++ b/Documentation/devicetree/bindings/drm/msm/hdmi.txt > >>@@ -12,16 +12,16 @@ Required properties: > >> - clocks: device clocks > >> - clock-names: Corresponding name for each entry in the clocks proper= ty. > >> for "qcom,hdmi-tx-8960" compatible names should be > >>- "core_clk" > >>- "master_iface_clk" > >>- "slave_iface_clk" > >>+ "core_clk" is deprecated, use "core" instead > >>+ "master_iface_clk" is deprecated, use "master_iface" instead > >>+ "slave_iface_clk" is deprecated, use "slave_iface" instead > >> > >> for "qcom,hdmi-tx-8084" and "qcom,hdmi-tx-8074" compatible names sho= uld be > >>- "extp_clk" > >>- "alt_iface_clk" > >>- "iface_clk" > >>- "core_clk" > >>- "mdp_core_clk" > >>+ "extp_clk" is deprecated, use "extp" instead > >>+ "alt_iface_clk" is deprecated, use "alt_iface" intstead > >>+ "iface_clk" is deprecated, use "iface" instead > >>+ "core_clk" is deprecated, use "core" instead > >>+ "mdp_core_clk" is deprecated, use "mdp_core" instead > > > >Shouldn't there be a driver counterpart of this to accept the new names? > Driver changes are in this same series "[PATCH RFC 5/5] drm/msm/hdmi: rem= ove > _clk suffix from clock names"(https://lkml.org/lkml/2015/8/10/453) I don't have that patch in my inbox. It looks to be doing things backwards (look up the deprecated name first). I think it should be: clk =3D devm_clk_get(dev, id); if (IS_ERR(clk)) { char clk_name[32]; snprintf(clk_name, sizeof(clk_name), "%s_clk", id); clk =3D devm_clk_get(dev, clk_name); if (IS_ERR(clk)) return clk; } Also note how I've dropped the ERR_CAST(), that's not useful here because you aren't actually casting, but simply returning clk. Thierry --Md/poaVZ8hnGTzuv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyKg+AAoJEN0jrNd/PrOhunkP/AoykDzpjVBctHGs1zxbsKif 00oqTVep5sbvJe/A7c6vfd3Fi0uhaxxhvePl6JGK32QbpPalk2zwWuA5H6W2kxlo mApTtNv1yMNIqzyg/02y+FSO8jUOOQ4Cjbd1mnNIcCEt6k7rUNSqwVjIAiYf+EPz iAo3rvdIyK5BH8Uqvk8S+7tDDQigguo9GgZlNoS/JLPTV4+zYw0znjwZTdl2gztv spwGkdB6/VoOooxvBJc6UQsWnzGDb3qg0oioh403enH5TH/pxFoeGdRcayzuM7vS 9ijKg4Ae1f+7N5CStUEEJM4tjWVNHdhvnb03T+TRgD45KYG4aqMqew8eaejnjh60 /3OfoT97tpwfaueDLoHdSBZKrGBfv9gwOnHoaqCXQT8Em6YUg9sJ4twyCThEN2k6 5eHZEKjRrWoOxq/vCiByp6klJdnegFYCYDWx8en5qQjcSvSWwWgzUJ89yg7HU7/X PSePidIcZ5QO+ywfVycsl4SJ46u12j3BV3/+5kWAyVL8X4ZaJoVC1Rea+jtSc7Hu cT+YMwtZ+7JN9gLVNQ/sMH3xOAX+95pONvn99XMSqlDFfv2k8ce0H6Da8ySdlcoK +5+C7zt1K1TzR+6d3ZmPWXmIqn7FxP+SsRmkY9c7dvD6yreVeg3q2Xcv4IO/15Je xheVGcuRlyJdSgr7PiSC =Uoe5 -----END PGP SIGNATURE----- --Md/poaVZ8hnGTzuv-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/