Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932693AbbHJSmT (ORCPT ); Mon, 10 Aug 2015 14:42:19 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:34353 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932576AbbHJSmR (ORCPT ); Mon, 10 Aug 2015 14:42:17 -0400 MIME-Version: 1.0 In-Reply-To: <1439081497-14986-6-git-send-email-paul.gortmaker@windriver.com> References: <1439081497-14986-1-git-send-email-paul.gortmaker@windriver.com> <1439081497-14986-6-git-send-email-paul.gortmaker@windriver.com> Date: Mon, 10 Aug 2015 20:42:16 +0200 Message-ID: Subject: Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular From: Joachim Eastwood To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 27 Hi Paul, On 9 August 2015 at 02:51, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > 8250/Kconfig:config SERIAL_8250_LPC18XX > 8250/Kconfig: bool "NXP LPC18xx/43xx serial port support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. The bool in KConfig is more or less a copy-paste mistake on my side. I really meant for this driver to be buildable as module and it builds just fine with 'm'. Want me send a patch changing it to tristate or will you handle it? regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/