Date: Mon, 10 Aug 2015 11:54:00 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: ralf@linux-mips.org, zajec5@gmail.com, paul@pwsan.com,
        galak@codeaurora.org, linux-api@vger.kernel.org,
        linux-kernel@vger.kernel.org, matt.fleming@intel.com, x86@kernel.org,
        linux-efi@vger.kernel.org, qemu-devel@nongnu.org, lersek@redhat.com,
        jordan.l.justen@intel.com, gleb@cloudius-systems.com,
        pbonzini@redhat.com, kraxel@redhat.com, eblake@redhat.com,
        rjones@redhat.com, kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH 2/3] kobject: export kset_find_obj() to be used from
 modules
Message-ID: <20150810185400.GC19646@kroah.com>
References: <cover.1439220623.git.somlo@cmu.edu>
 <5c2bafb073e1386e39c4f73a83e7d835547b6b1f.1439220623.git.somlo@cmu.edu>
 <20150810183304.GC18817@kroah.com>
 <20150810184310.GM31816@HEDWIG.INI.CMU.EDU>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150810184310.GM31816@HEDWIG.INI.CMU.EDU>
User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1705
Lines: 45

On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote:
> On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote:
> > On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote:
> > > From: "Gabriel Somlo" <somlo@cmu.edu>
> > > 
> > > Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
> > > ---
> > >  lib/kobject.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/lib/kobject.c b/lib/kobject.c
> > > index 3e3a5c3..f9754a0 100644
> > > --- a/lib/kobject.c
> > > +++ b/lib/kobject.c
> > > @@ -1058,3 +1058,4 @@ EXPORT_SYMBOL(kobject_del);
> > >  
> > >  EXPORT_SYMBOL(kset_register);
> > >  EXPORT_SYMBOL(kset_unregister);
> > > +EXPORT_SYMBOL(kset_find_obj);
> > 
> > checkpatch doesn't like this for obvious reasons :)
> 
> When I run checkpatch on this one, it comes back fine. Could you
> please elaborate ?
> 
> [staging]$ scripts/checkpatch.pl
> 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch 
> total: 0 errors, 0 warnings, 4 lines checked
> 
> 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch has no
> obvious style problems and is ready for submission.

EXPORT_SYMBOL() should be below the function definition itself, not at
the bottom of the file.  Odd that checkpatch doesn't catch this when
done in this manner, it will if you run it on the whole file after your
patch is applied (along with the existing problems.)

But this is a minor issue, see my other review first...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/