Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932596AbbHJTNo (ORCPT ); Mon, 10 Aug 2015 15:13:44 -0400 Received: from mail-db3on0099.outbound.protection.outlook.com ([157.55.234.99]:2875 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754381AbbHJTNl convert rfc822-to-8bit (ORCPT ); Mon, 10 Aug 2015 15:13:41 -0400 From: Noam Camus To: Greg KH CC: "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" Subject: Re: [v2 2/3] serial: 8250_dw: dw8250_setup_port() use endianness aware read. Thread-Topic: [v2 2/3] serial: 8250_dw: dw8250_setup_port() use endianness aware read. Thread-Index: AQHQx19pmYEvq8pv5EerYlOFQypbv536/VWAgAq0voo= Date: Mon, 10 Aug 2015 19:13:39 +0000 Message-ID: References: <1437557699-25722-1-git-send-email-noamc@ezchip.com> <1437886478-29273-1-git-send-email-noamc@ezchip.com> <1437886478-29273-2-git-send-email-noamc@ezchip.com> <1437886478-29273-3-git-send-email-noamc@ezchip.com>,<20150803234221.GA5257@kroah.com> In-Reply-To: <20150803234221.GA5257@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=noamc@ezchip.com; x-originating-ip: [212.179.42.66] x-microsoft-exchange-diagnostics: 1;DB4PR02MB269;5:LmIldkZJgwDK9cq2MZZ0fDPFNVKrCJbvGDy+hW+X27m9yEp1+k5Ne2tf2p6/vQvN/ktCAuPm344p72iOpZope1nE3MakhZCEBjFgerlQWMTcs/+2LmlUKCg2HtM3tcHwNHfLowWozynlOBuCtfW9WA==;24:cAJplgjguS/LqQ/k068kVSIqjICjizmUMXViq7xuaeqbv7yurhgab2f4aFQ+mqdqszSkiv9bZpPkIjD+ofTUbOcu8QwgtrQcBLQIWEIrpaE=;20:3VS4QKcvxzvr+IqHmx1pQ2kQrmqJZZB11wzo4fgzF/ZMqVvsx0TLsNtygPhuHwDH6OdP0p4Qy5jYUOvcxOzIzw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB269; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB4PR02MB269;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB269; x-forefront-prvs: 06640999CA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(199003)(377454003)(10400500002)(50986999)(5001960100002)(2950100001)(110136002)(189998001)(101416001)(105586002)(77156002)(40100003)(106116001)(122556002)(106356001)(62966003)(46102003)(5001830100001)(5003600100002)(5002640100001)(86362001)(66066001)(76176999)(87936001)(5001860100001)(2900100001)(19580395003)(93886004)(68736005)(76576001)(4001540100001)(33656002)(74316001)(81156007)(2656002)(64706001)(102836002)(97736004)(77096005)(54356999)(92566002)(19580405001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR02MB269;H:DB4PR02MB272.eurprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2015 19:13:39.6983 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB269 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 21 From: Greg KH Sent: Tuesday, August 4, 2015 2:42 AM > > - reg = readl(p->membase + DW_UART_CPR); > > + reg = (p->iotype == UPIO_MEM32BE) ? > > + ioread32be(p->membase + DW_UART_CPR) : > > + readl(p->membase + DW_UART_CPR); > > Same here. > > And shouldn't all of this be "hidden" behind something else? You should not have to do this for each readl call... > As I wrote for last patch, I will add another level for accessors and use it here. Noam-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/