Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932758AbbHJTvx (ORCPT ); Mon, 10 Aug 2015 15:51:53 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35654 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932423AbbHJTvr (ORCPT ); Mon, 10 Aug 2015 15:51:47 -0400 Message-ID: <55C900D0.9060606@gmail.com> Date: Mon, 10 Aug 2015 21:51:44 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 To: Antoine Tenart , thierry.reding@gmail.com CC: zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] ARM: berlin: add a PWM node on the BG2 References: <1438248201-29222-1-git-send-email-antoine.tenart@free-electrons.com> <1438248201-29222-5-git-send-email-antoine.tenart@free-electrons.com> In-Reply-To: <1438248201-29222-5-git-send-email-antoine.tenart@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1405 Lines: 44 On 30.07.2015 11:23, Antoine Tenart wrote: > This patch adds a PWM node in the Berlin BG2 device tree, using the > newly added Berlin PWM driver. > > Signed-off-by: Antoine Tenart > --- > arch/arm/boot/dts/berlin2.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi > index ef811de09908..e17bd5faed27 100644 > --- a/arch/arm/boot/dts/berlin2.dtsi > +++ b/arch/arm/boot/dts/berlin2.dtsi > @@ -512,5 +512,11 @@ > interrupts = ; > }; > }; > + > + pwm: pwm@f20000 { > + compatible = "marvell,berlin-pwm"; > + reg = <0xf20000 0x40>; > + #pwm-cells = <3>; > + }; I only checked berlin2.dtsi: The top most line with belongs to a sub-node of apb@fc0000 - which means that the pwm node isn't sorted in by address. Please sort the nodes by address in all three DT patches. BTW, is there any IRQ from the PWM IP routed to any intc upstream? A quick look into some BSP code does not reveal any hints maybe one of the Marvell guys can comment on it. Sebastian > }; > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/