Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932751AbbHJUKl (ORCPT ); Mon, 10 Aug 2015 16:10:41 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:34938 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754636AbbHJUKj (ORCPT ); Mon, 10 Aug 2015 16:10:39 -0400 MIME-Version: 1.0 In-Reply-To: <20150810153835.GC13461@kroah.com> References: <1439187861-3864-1-git-send-email-mike.rapoport@gmail.com> <20150810153835.GC13461@kroah.com> Date: Mon, 10 Aug 2015 23:10:37 +0300 Message-ID: Subject: Re: [PATCH 0/6] staging: android: allow building some drivers as a module From: Mike Rapoport To: Greg Kroah-Hartman Cc: Brian Swetland , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 876 Lines: 32 On Mon, Aug 10, 2015 at 6:38 PM, Greg Kroah-Hartman wrote: > On Mon, Aug 10, 2015 at 09:24:15AM +0300, Mike Rapoport wrote: >> Hi, >> >> These patches enable building of timed_gpio, sync* and ashmem as a module > > Why do you want to do this? Apparently I've misread "- make sure things build as modules properly" line in drivers/staging/android/TODO... My bad. > Does it ever make sense to do this type of > thing for your kernel? What does changing these to modules enable you > to do differently? > > As it is, I think the code should stay non-modular. > > thanks, > > greg k-h -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/