Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932934AbbHJVDV (ORCPT ); Mon, 10 Aug 2015 17:03:21 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60887 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932575AbbHJVDU (ORCPT ); Mon, 10 Aug 2015 17:03:20 -0400 X-Sasl-enc: RGVG3VVBEbq3SObCfJhKZQyAh8nAyXTuaq5jaQQO+fRK 1439240599 Date: Mon, 10 Aug 2015 14:03:18 -0700 From: Greg Kroah-Hartman To: Mike Rapoport Cc: Brian Swetland , LKML Subject: Re: [PATCH 0/6] staging: android: allow building some drivers as a module Message-ID: <20150810210318.GA10379@kroah.com> References: <1439187861-3864-1-git-send-email-mike.rapoport@gmail.com> <20150810153835.GC13461@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 27 On Mon, Aug 10, 2015 at 11:10:37PM +0300, Mike Rapoport wrote: > On Mon, Aug 10, 2015 at 6:38 PM, Greg Kroah-Hartman wrote: > > On Mon, Aug 10, 2015 at 09:24:15AM +0300, Mike Rapoport wrote: > >> Hi, > >> > >> These patches enable building of timed_gpio, sync* and ashmem as a module > > > > Why do you want to do this? > > Apparently I've misread "- make sure things build as modules properly" > line in drivers/staging/android/TODO... > My bad. Nope, not your fault, I forgot about that. We should remove that TODO item, as it doesn't make sense for these "non-discoverable" modules to be built as a module. Care to make a patch for that? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/