Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754916AbbHKBGu (ORCPT ); Mon, 10 Aug 2015 21:06:50 -0400 Received: from mga11.intel.com ([192.55.52.93]:51465 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752609AbbHKBGt (ORCPT ); Mon, 10 Aug 2015 21:06:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,649,1432623600"; d="scan'208";a="623011045" Subject: Re: [Bugfix] x86, irq: Fix a regression caused by commit b5dc8e6c21e7 To: Alex Deucher References: <1439108128-18441-1-git-send-email-jiang.liu@linux.intel.com> Cc: Thomas Gleixner , Alexander Holler , Mark Rustad , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Tony Luck , LKML From: Jiang Liu Organization: Intel Message-ID: <55C94AA5.8090904@linux.intel.com> Date: Tue, 11 Aug 2015 09:06:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7987 Lines: 178 On 2015/8/10 23:00, Alex Deucher wrote: > On Sun, Aug 9, 2015 at 4:15 AM, Jiang Liu wrote: >> Alex Deucher, Mark Rustad and Alexander Holler reported a regression >> with the latest v4.2-rc4 kernel, which breaks some SATA controllers. >> With multi-MSI capable SATA controllers, only the first port works, >> all other ports times out when executing SATA commands. This regression >> bisects to 52f518a3a7c2 ("x86/MSI: Use hierarchical irqdomains to manage >> MSI interrupts"), but it's not the root cause, it just triggers a bug >> caused by b5dc8e6c21e7 ("x86/irq: Use hierarchical irqdomain to manage >> CPU interrupt vectors"). >> >> With this patch applied, the affected SATA controllers work as expected. > > Yes, this fixes the SATA regression: > Tested-by: Alex Deucher > > I'm not sure if it's related to this patch or not (I haven't bisected > it independently yet), but MSIs don't seem to work on GPUs. See the > line for amdgpu. This is just after loading the driver. Hi Alex, This patch only affects multiple-MSI, and it seems that your gpu only uses one MSI interrupt, so it may not be related to this patch. And this seems like a sort of interrupt storm. > 52: 16579895 16579562 16580988 16583443 IR-PCI-MSI > 524288-edge amdgpu Does it make any change by disable interrupt remapping? Does it make any change by disable MSI? Thanks! Gerry > > $ cat /proc/interrupts > CPU0 CPU1 CPU2 CPU3 > 0: 138 0 0 0 IR-IO-APIC > 2-edge timer > 1: 2 2 1 4 IR-IO-APIC > 1-edge i8042 > 7: 1 0 0 0 IR-IO-APIC 7-edge > 8: 0 0 1 0 IR-IO-APIC > 8-edge rtc0 > 9: 0 0 0 0 IR-IO-APIC > 9-fasteoi acpi > 14: 0 0 0 0 IR-IO-APIC > 14-edge pata_atiixp > 15: 0 0 0 0 IR-IO-APIC > 15-edge pata_atiixp > 16: 302 303 301 314 IR-IO-APIC > 16-fasteoi snd_hda_intel > 17: 0 0 0 0 IR-IO-APIC > 17-fasteoi ehci_hcd:usb7, ehci_hcd:usb8 > 18: 0 0 0 0 IR-IO-APIC > 18-fasteoi ohci_hcd:usb9, ohci_hcd:usb10, ohci_hcd:usb11 > 24: 0 0 0 1 PCI-MSI 4096-edge > AMD-Vi > 26: 0 0 0 0 IR-PCI-MSI > 34816-edge PCIe PME > 27: 0 0 0 0 IR-PCI-MSI > 344064-edge PCIe PME > 28: 0 0 0 0 IR-PCI-MSI > 348160-edge PCIe PME > 29: 0 0 0 0 IR-PCI-MSI > 350208-edge PCIe PME > 30: 247 255 1381 4617 IR-PCI-MSI > 278528-edge ahci0 > 31: 162 163 164 181 IR-PCI-MSI > 278529-edge ahci1 > 34: 2 1 2 17 IR-PCI-MSI > 262144-edge xhci_hcd > 35: 0 0 0 0 IR-PCI-MSI > 262145-edge xhci_hcd > 36: 0 0 0 0 IR-PCI-MSI > 262146-edge xhci_hcd > 37: 0 0 0 0 IR-PCI-MSI > 262147-edge xhci_hcd > 38: 0 0 0 0 IR-PCI-MSI > 262148-edge xhci_hcd > 39: 0 0 0 0 IR-PCI-MSI > 264192-edge xhci_hcd > 40: 0 0 0 0 IR-PCI-MSI > 264193-edge xhci_hcd > 41: 0 0 0 0 IR-PCI-MSI > 264194-edge xhci_hcd > 42: 0 0 0 0 IR-PCI-MSI > 264195-edge xhci_hcd > 43: 0 0 0 0 IR-PCI-MSI > 264196-edge xhci_hcd > 44: 0 0 0 0 IR-PCI-MSI > 2097152-edge xhci_hcd > 45: 0 0 0 0 IR-PCI-MSI > 2097153-edge xhci_hcd > 46: 0 0 0 0 IR-PCI-MSI > 2097154-edge xhci_hcd > 47: 0 0 0 0 IR-PCI-MSI > 2097155-edge xhci_hcd > 48: 0 0 0 0 IR-PCI-MSI > 2097156-edge xhci_hcd > 50: 40 41 41 40 IR-PCI-MSI > 526336-edge snd_hda_intel > 51: 14 15 21 1105 IR-PCI-MSI > 2621440-edge em1 > 52: 16579895 16579562 16580988 16583443 IR-PCI-MSI > 524288-edge amdgpu > NMI: 4 3 4 3 Non-maskable interrupts > LOC: 15020 10425 8933 8584 Local timer interrupts > SPU: 0 0 0 0 Spurious interrupts > PMI: 4 3 4 3 Performance > monitoring interrupts > IWI: 1 1 1 1 IRQ work interrupts > RTR: 0 0 0 0 APIC ICR read retries > RES: 7203 5501 10621 5077 Rescheduling interrupts > CAL: 498 559 614 591 Function call interrupts > TLB: 58 149 104 95 TLB shootdowns > TRM: 0 0 0 0 Thermal event interrupts > THR: 0 0 0 0 Threshold APIC interrupts > DFR: 0 0 0 0 Deferred Error > APIC interrupts > MCE: 0 0 0 0 Machine check exceptions > MCP: 1 1 1 1 Machine check polls > HYP: 0 0 0 0 Hypervisor > callback interrupts > ERR: 1 > MIS: 0 > PIN: 0 0 0 0 Posted-interrupt > notification event > PIW: 0 0 0 0 Posted-interrupt > wakeup event > > This worked fine on 4.1. Any ideas? > > Thanks, > > Alex > > >> >> Signed-off-by: Jiang Liu >> Reported-by: Alex Deucher >> Reported-by: Mark Rustad >> Reported-by: Alexander Holler >> --- >> Hi Alex, Mark and Alexandler, >> Sorry for the long delay to root cause this regression, it's >> really annoying. Could you please help test this patch against the >> latest v4.2-rcx? >> Thanks! >> Gerry >> --- >> arch/x86/kernel/apic/vector.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c >> index f813261d9740..2683f36e4e0a 100644 >> --- a/arch/x86/kernel/apic/vector.c >> +++ b/arch/x86/kernel/apic/vector.c >> @@ -322,7 +322,7 @@ static int x86_vector_alloc_irqs(struct irq_domain *domain, unsigned int virq, >> irq_data->chip = &lapic_controller; >> irq_data->chip_data = data; >> irq_data->hwirq = virq + i; >> - err = assign_irq_vector_policy(virq, irq_data->node, data, >> + err = assign_irq_vector_policy(virq + i, irq_data->node, data, >> info); >> if (err) >> goto error; >> -- >> 1.7.10.4 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/