Message-ID: <55C94AB1.30108@redhat.com>
Date: Mon, 10 Aug 2015 21:06:57 -0400
From: Rik van Riel <riel@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, mingo@redhat.com,
        peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/numa: Fix NUMA_DIRECT topology identification
References: <1439256048-3748-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
In-Reply-To: <1439256048-3748-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1091
Lines: 32

On 08/10/2015 09:20 PM, Aravind Gopalakrishnan wrote:
> Systems which have all nodes at a distance of at most
> 1 hop should be identified as 'NUMA_DIRECT'.
> 
> However, the scheduler incorrectly identifies it as
> 'NUMA_BACKPLANE'. This is because 'n' is assigned to
> sched_max_numa_distance but the code (mis)interprets it
> to mean 'number of hops'.
> 
> Rik had actually used sched_domains_numa_levels for detecting
> a 'NUMA_DIRECT' topology-
> http://marc.info/?l=linux-kernel&m=141279712429834&w=2
> 
> But that was changed when he removed the hops table in the
> subsequent version-
> http://marc.info/?l=linux-kernel&m=141353106106771&w=2

Good catch! Thank you!

> Fixing the issue here.
> 
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/