Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933578AbbHKCNI (ORCPT ); Mon, 10 Aug 2015 22:13:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56119 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933453AbbHKCNG convert rfc822-to-8bit (ORCPT ); Mon, 10 Aug 2015 22:13:06 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <24179.1438990638@warthog.procyon.org.uk> <10448.1439166147@warthog.procyon.org.uk> To: James Morris Cc: dhowells@redhat.com, mcgrof@gmail.com, zohar@linux.vnet.ibm.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [GIT PULL] MODSIGN: Use PKCS#7 for module signatures [ver #7] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6892.1439259180.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Tue, 11 Aug 2015 03:13:00 +0100 Message-ID: <6893.1439259180@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 42 James Morris wrote: > On Mon, 10 Aug 2015, David Howells wrote: > > > James Morris wrote: > > > > > I get a build failure: > > > > > > HOSTCC scripts/sign-file > > > scripts/sign-file.c:20:25: error: openssl/bio.h: No such file or directory > > > > > > followed by many lines of error. > > > > What openssl do you have installed and do you have the -devel packages for it > > installed? In particular libcrypto. > > openssl-1.0.1e-30.el6.11.x86_64 > > and not the devel packages. Yeah, you need the openssl-devel package now. There's some stuff using the library directly allows us to do that you can't do with just the command line tool. This is mentioned in the MODSIGN: Provide a utility to append a PKCS#7 signature to a module commit description. Note that the utility is written in C and must be linked against the OpenSSL crypto library. Would it help to update the module-signing.txt document, the config option or the git pull request/cover note? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/