Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933607AbbHKCus (ORCPT ); Mon, 10 Aug 2015 22:50:48 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:61589 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932991AbbHKCur (ORCPT ); Mon, 10 Aug 2015 22:50:47 -0400 Date: Tue, 11 Aug 2015 10:46:50 +0800 From: Jisheng Zhang To: Sebastian Hesselbarth CC: Antoine Tenart , , , , , Subject: Re: [PATCH v2 4/5] ARM: berlin: add a PWM node on the BG2 Message-ID: <20150811104650.0e19ba41@xhacker> In-Reply-To: <55C900D0.9060606@gmail.com> References: <1438248201-29222-1-git-send-email-antoine.tenart@free-electrons.com> <1438248201-29222-5-git-send-email-antoine.tenart@free-electrons.com> <55C900D0.9060606@gmail.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-08-11_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 kscore.is_bulkscore=0 kscore.compositescore=1 compositescore=0.9 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 rbsscore=0.9 spamscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1508110045 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1629 Lines: 48 Dear Sebastian, On Mon, 10 Aug 2015 21:51:44 +0200 Sebastian Hesselbarth wrote: > On 30.07.2015 11:23, Antoine Tenart wrote: > > This patch adds a PWM node in the Berlin BG2 device tree, using the > > newly added Berlin PWM driver. > > > > Signed-off-by: Antoine Tenart > > --- > > arch/arm/boot/dts/berlin2.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi > > index ef811de09908..e17bd5faed27 100644 > > --- a/arch/arm/boot/dts/berlin2.dtsi > > +++ b/arch/arm/boot/dts/berlin2.dtsi > > @@ -512,5 +512,11 @@ > > interrupts = ; > > }; > > }; > > + > > + pwm: pwm@f20000 { > > + compatible = "marvell,berlin-pwm"; > > + reg = <0xf20000 0x40>; > > + #pwm-cells = <3>; > > + }; > > I only checked berlin2.dtsi: > The top most line with belongs to a sub-node of > apb@fc0000 - which means that the pwm node isn't sorted in by > address. Please sort the nodes by address in all three DT patches. > > BTW, is there any IRQ from the PWM IP routed to any intc upstream? > A quick look into some BSP code does not reveal any hints maybe > one of the Marvell guys can comment on it. There's no interrupt for the PWM in all berlin SoCs ;) Thanks, Jisheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/