Date: Mon, 10 Aug 2015 21:22:56 -0700 (PDT)
Message-Id: <20150810.212256.1658635789817625453.davem@davemloft.net>
To: jmaxwell37@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jmaxwell@redhat.com
Subject: Re: [PATCH net] netconsole: Check for carrier before calling
 netpoll_send_udp()
From: David Miller <davem@davemloft.net>
In-Reply-To: <1439256746-7953-1-git-send-email-jmaxwell37@gmail.com>
References: <1439256746-7953-1-git-send-email-jmaxwell37@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 818
Lines: 20

From: Jon Maxwell <jmaxwell37@gmail.com>
Date: Tue, 11 Aug 2015 11:32:26 +1000

> We have seen a few crashes recently where a NIC is getting
> reset for some reason and then the driver or another module calls
> printk() which invokes netconsole. Netconsole then calls the
> adapter specific poll routine via netpoll which crashes because 
> the adapter is resetting and its structures are being reinitialized.

This isn't a fix.

What if the carrier check passes, and then the chip reset starts on
another cpu?  You'll have the same problem.

I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/