Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbbHKEma (ORCPT ); Tue, 11 Aug 2015 00:42:30 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:51597 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbbHKEm2 (ORCPT ); Tue, 11 Aug 2015 00:42:28 -0400 Message-ID: <55C97D2C.6090505@roeck-us.net> Date: Mon, 10 Aug 2015 21:42:20 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Daniel Kurtz , Matthias Brugger CC: Eddie Huang , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org, "linux-kernel@vger.kernel.org" , Sascha Hauer , Greta Zhang Subject: Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled References: <1437630551-39650-1-git-send-email-eddie.huang@mediatek.com> <1437630551-39650-3-git-send-email-eddie.huang@mediatek.com> <1488521.5eJqASov2O@ubix> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 39 On 08/10/2015 09:28 PM, Daniel Kurtz wrote: > Hi Guenter, Matthias, > > On Fri, Jul 24, 2015 at 1:37 AM, Matthias Brugger > wrote: >> On Thursday, July 23, 2015 01:49:11 PM Eddie Huang wrote: >>> From: Greta Zhang >>> >>> Without .shutdown(), watchdog might reset the system during power off. >>> For example, if watchdog's timeout is set to 30s, then it is reset to >>> zero by mtk_wdt_ping(). During power off, no app will ping watchdog, >>> but watchdog is still running and may trigger reset. >>> >>> Signed-off-by: Greta Zhang >>> Signed-off-by: Eddie Huang >>> --- >>> drivers/watchdog/mtk_wdt.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >> >> Acked-by: Matthias Brugger > > is the plan to land these two patches via Guenter's watchdog tree [0]? > [0] git://www.linux-watchdog.org/linux-watchdog.git > That is Wim's tree, and Wim is the maintainer ;-). I have the patches queued in my tree [1], and I plan to send a pull request to Wim this week or early next week. Guenter --- [1] https://git.kernel.org/cgit/linux/kernel/git/groeck/linux-staging.git/log/?h=watchdog-next -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/