Subject: Re: [RFC PATCH] mmc: sdhci-of-arasan: Add the support for sdhci-5.1
To: Shawn Lin <shawn.lin@rock-chips.com>,
        Michal Simek <michal.simek@xilinx.com>,
        =?UTF-8?Q?S=c3=b6ren_Brinkmann?= <soren.brinkmann@xilinx.com>
References: <1439256888-6658-1-git-send-email-shawn.lin@rock-chips.com>
CC: Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
From: Michal Simek <michal.simek@xilinx.com>
Message-ID: <55C982DB.30208@xilinx.com>
Date: Tue, 11 Aug 2015 07:06:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <1439256888-6658-1-git-send-email-shawn.lin@rock-chips.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2015 05:06:50.4610
 (UTC)
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB033
X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB040;2:y1J/CjcRCXwI4+KAQc15SH99eawjRgkaDkRr9LqMhWztB0OG3K2rLdulXL5+JUDImpY2wjHxEl8JiyWH/bIjN0LhvuFP1/TiK3QVsCAoYE+CCcubt7BD2eC+iHlFZQSJfU4d8lsjQfUJGoWKVfs0M/zbrgzNrTHkqBZpuUhy4RI=;3:Ty1aVXL7Xx3JX++9R5csZDKp/8d4ubG0pCDvohuKOxOMiI5muFvwUS2H79XsOTPosONNX9WDmrKW62IZfhsv4qWKj08lj2JSfyANs9RDLZh4GQmbUF9URR4C0pzCKJje16Z8zktifah3poY/VCccs8yQEo4jRxeY/z/oy1VsSsIvwwNkqXyVL85osogcgjeZVMVBX1b2PK8KrnStnIyVtstpPkF7RyQWkC2UaYetsgQ=;25:OSw263gjLtwVQRkGpv1MpFltIsg5ouF9b0cG5Pcujcq2AXCCVilJA6+xR8LyKlaSCdHn4ED4Yo8j4YOObEewDFM65drJwKb7oSqx0yyHwuFiFRDdyPx9hjHdTfCNoDmrYXRwD4ImWrYKd3bsAb46hHqTHROI/YD01dBlgVM4FqzdfvFSPeEXyqTEDZTrN02jm10ZrKkMexJFY8DFw5n/MymAIPj94Vtebhw35uFxj71p8F1NvOsr9behtq8sDdoyIl4mxOgrTbN/Fi39fDF0Aw==;23:mkYSJXhfiJ+ZlC2uroiz3wAGo3qra4dfPB+CX24CqQW+LbhYNrhFTEGZPDwT10ABvxzlbK0fw2vIahfcK4IHV5NPZOu9QPrbzqmci1K02LekReN17r9k5/uWTZArSykSCS/e1nCAtzkTYYfnKw+HF4UTjP17d8mxZMp11vStffFEZ8z+oP7mOFx6UN9p+kZJ
X-OriginatorOrg: xilinx.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2296
Lines: 48

On 08/11/2015 03:34 AM, Shawn Lin wrote:
> This patch adds the quirks and compatible string in sdhci-of-arasan.c
> to support sdhci-arasan5.1 version of controller. No documented controller
> IP version is found in the TRM, so we use ths version of command queueing
> engine integrated into this controller by arasan to specify our controller.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> 
> ---
> 
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
>  drivers/mmc/host/sdhci-of-arasan.c                     | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 7e94903..da541c3 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
>  
>  Required Properties:
>    - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
> -                'arasan,sdhci-4.9a'
> +                'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
>    - reg: From mmc bindings: Register location and length.
>    - clocks: From clock bindings: Handles to clock inputs.
>    - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index ef5a7d2..c9012f5 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -175,6 +175,9 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>  	if (of_device_is_compatible(pdev->dev.of_node, "arasan,sdhci-4.9a")) {
>  		host->quirks |= SDHCI_QUIRK_NO_HISPD_BIT;
>  		host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23;
> +	} else if (of_device_is_compatible(pdev->dev.of_node,
> +					   "arasan,sdhci-5.1")) {
> +		host->quirks |= SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN;

Is this broken Arasan version or just broken capability on your SoC?

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/