Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755312AbbHKFhw (ORCPT ); Tue, 11 Aug 2015 01:37:52 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46391 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbbHKFhv (ORCPT ); Tue, 11 Aug 2015 01:37:51 -0400 Date: Mon, 10 Aug 2015 22:37:50 -0700 (PDT) Message-Id: <20150810.223750.1908561238664673104.davem@davemloft.net> To: yalin.wang2010@gmail.com Cc: joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro From: David Miller In-Reply-To: <39055924-5AA5-4DE0-8872-D2F107EA82F1@gmail.com> References: <1FEC219B-7AF2-47C9-8EBB-786EE6EADCE4@gmail.com> <39055924-5AA5-4DE0-8872-D2F107EA82F1@gmail.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 10 Aug 2015 22:37:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 30 From: yalin wang Date: Tue, 11 Aug 2015 13:11:22 +0800 > HWM_REVERSE() macro is unused, remove it. > > Signed-off-by: yalin wang You did not do as I asked you to, this patch is still corrupted and there is no way you successfully applied what is in this patch. > -#define HWM_REVERSE(x) ((((x)<<24L)&0xff000000L) + \ > - (((x)<< 8L)&0x00ff0000L) + \ > - (((x)>> 8L)&0x0000ff00L) + \ > - (((x)>>24L)&0x000000ffL)) This indentation here is spaces, whereas in the source files they are TABS. Your email client did this. If you fail to properly verify that your outgoing patches are not corrupted before submitting them here, I will stop reviewing and considering your changes. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/