Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755036AbbHKFvB (ORCPT ); Tue, 11 Aug 2015 01:51:01 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:33688 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753094AbbHKFvA convert rfc822-to-8bit (ORCPT ); Tue, 11 Aug 2015 01:51:00 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro From: yalin wang In-Reply-To: <20150810.223750.1908561238664673104.davem@davemloft.net> Date: Tue, 11 Aug 2015 13:50:56 +0800 Cc: joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <03416E4A-6121-41C4-B209-AD60308FE317@gmail.com> References: <1FEC219B-7AF2-47C9-8EBB-786EE6EADCE4@gmail.com> <39055924-5AA5-4DE0-8872-D2F107EA82F1@gmail.com> <20150810.223750.1908561238664673104.davem@davemloft.net> To: David Miller X-Mailer: Apple Mail (2.2098) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 35 > On Aug 11, 2015, at 13:37, David Miller wrote: > > From: yalin wang > Date: Tue, 11 Aug 2015 13:11:22 +0800 > >> HWM_REVERSE() macro is unused, remove it. >> >> Signed-off-by: yalin wang > > You did not do as I asked you to, this patch is still corrupted > and there is no way you successfully applied what is in this patch. > >> -#define HWM_REVERSE(x) ((((x)<<24L)&0xff000000L) + \ >> - (((x)<< 8L)&0x00ff0000L) + \ >> - (((x)>> 8L)&0x0000ff00L) + \ >> - (((x)>>24L)&0x000000ffL)) > > This indentation here is spaces, whereas in the source files they > are TABS. > > Your email client did this. > > If you fail to properly verify that your outgoing patches are not > corrupted before submitting them here, I will stop reviewing and > considering your changes. > > Thank you. ouch, i am sorry that i am sending from windows PC, let me check that . Sorry for that .-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/