Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755110AbbHKFxU (ORCPT ); Tue, 11 Aug 2015 01:53:20 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:36035 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753261AbbHKFxS (ORCPT ); Tue, 11 Aug 2015 01:53:18 -0400 MIME-Version: 1.0 In-Reply-To: <20150810.212256.1658635789817625453.davem@davemloft.net> References: <1439256746-7953-1-git-send-email-jmaxwell37@gmail.com> <20150810.212256.1658635789817625453.davem@davemloft.net> Date: Tue, 11 Aug 2015 15:53:18 +1000 Message-ID: Subject: Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp() From: Jonathan Maxwell To: David Miller Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jon Maxwell Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 26 > What if the carrier check passes, and then the chip reset starts on > another cpu? You'll have the same problem. Okay, let me see if I can come up with a better way to mitigate this. On Tue, Aug 11, 2015 at 2:22 PM, David Miller wrote: > From: Jon Maxwell > Date: Tue, 11 Aug 2015 11:32:26 +1000 > >> We have seen a few crashes recently where a NIC is getting >> reset for some reason and then the driver or another module calls >> printk() which invokes netconsole. Netconsole then calls the >> adapter specific poll routine via netpoll which crashes because >> the adapter is resetting and its structures are being reinitialized. > > This isn't a fix. > > What if the carrier check passes, and then the chip reset starts on > another cpu? You'll have the same problem. > > I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/