Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755014AbbHKGG2 (ORCPT ); Tue, 11 Aug 2015 02:06:28 -0400 Received: from mail1.windriver.com ([147.11.146.13]:34235 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754649AbbHKGG0 (ORCPT ); Tue, 11 Aug 2015 02:06:26 -0400 Date: Tue, 11 Aug 2015 02:05:44 -0400 From: Paul Gortmaker To: Joachim Eastwood CC: "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Jiri Slaby , , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular Message-ID: <20150811060544.GJ9751@windriver.com> References: <1439081497-14986-1-git-send-email-paul.gortmaker@windriver.com> <1439081497-14986-6-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 36 [Re: [PATCH 5/5] drivers/tty: make serial 8250_lpc18xx.c explicitly non-modular] On 10/08/2015 (Mon 20:42) Joachim Eastwood wrote: > Hi Paul, > > On 9 August 2015 at 02:51, Paul Gortmaker wrote: > > The Kconfig currently controlling compilation of this code is: > > > > 8250/Kconfig:config SERIAL_8250_LPC18XX > > 8250/Kconfig: bool "NXP LPC18xx/43xx serial port support" > > > > ...meaning that it currently is not being built as a module by anyone. > > > > Lets remove the modular code that is essentially orphaned, so that > > when reading the driver there is no doubt it is builtin-only. > > The bool in KConfig is more or less a copy-paste mistake on my side. I > really meant for this driver to be buildable as module and it builds > just fine with 'm'. > > Want me send a patch changing it to tristate or will you handle it? I will do a v2 in the next day or so with collected ACKs and this patch replaced, unless Greg jumps in and indicates he'd like something different. Paul. -- > > > regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/