Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755332AbbHKGhA (ORCPT ); Tue, 11 Aug 2015 02:37:00 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:38749 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755060AbbHKGg7 (ORCPT ); Tue, 11 Aug 2015 02:36:59 -0400 Date: Tue, 11 Aug 2015 08:36:55 +0200 From: Michal Hocko To: Joonsoo Kim Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Shaohua Li , Vlastimil Babka , Eric Dumazet Subject: Re: [PATCH v2] mm/slub: don't wait for high-order page allocation Message-ID: <20150811063655.GC18998@dhcp22.suse.cz> References: <1438913403-3682-1-git-send-email-iamjoonsoo.kim@lge.com> <20150807150501.GJ30785@dhcp22.suse.cz> <20150810004022.GC26074@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150810004022.GC26074@js1304-P5Q-DELUXE> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 36 On Mon 10-08-15 09:40:22, Joonsoo Kim wrote: > On Fri, Aug 07, 2015 at 05:05:01PM +0200, Michal Hocko wrote: > > On Fri 07-08-15 11:10:03, Joonsoo Kim wrote: > > [...] > > > diff --git a/mm/slub.c b/mm/slub.c > > > index 257283f..52b9025 100644 > > > --- a/mm/slub.c > > > +++ b/mm/slub.c > > > @@ -1364,6 +1364,8 @@ static struct page *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) > > > * so we fall-back to the minimum order allocation. > > > */ > > > alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY) & ~__GFP_NOFAIL; > > > + if ((alloc_gfp & __GFP_WAIT) && oo_order(oo) > oo_order(s->min)) > > > + alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~__GFP_WAIT; > > > > Wouldn't it be preferable to "fix" the __GFP_WAIT behavior than spilling > > __GFP_NOMEMALLOC around the kernel? GFP flags are getting harder and > > harder to use right and that is a signal we should thing about it and > > unclutter the current state. > > Maybe, it is preferable. Could you try that? I will try to cook up something during the week. > Anyway, it is separate issue so I don't want pending this patch until > that change. OK, fair enough, at least this one is in mm proper... -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/