Message-ID: <55C9B131.50108@iogearbox.net>
Date: Tue, 11 Aug 2015 10:24:17 +0200
From: Daniel Borkmann <daniel@iogearbox.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Kaixu Xia <xiakaixu@huawei.com>, fengguang.wu@intel.com,
        davem@davemloft.net, ast@plumgrid.com, schwidefsky@de.ibm.com,
        heiko.carstens@de.ibm.com
CC: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, wangnan0@huawei.com,
        Michael Holzheu <holzheu@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 net-next] bpf: s390: Fix build error caused by the
 struct bpf_array member name changed
References: <1439276026-60789-1-git-send-email-xiakaixu@huawei.com>
In-Reply-To: <1439276026-60789-1-git-send-email-xiakaixu@huawei.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 835
Lines: 22

On 08/11/2015 08:53 AM, Kaixu Xia wrote:
> There is a build error that "'struct bpf_array' has no member
> named 'prog'" on s390. In commit 2a36f0b, the member 'prog' of
> struct bpf_array is replaced by 'ptrs'. So this patch fixes it.
>
> Signed-off-by: Kaixu Xia <xiakaixu@huawei.com>

You were also asked to add a proper Fixes tag :

Fixes: 2a36f0b92eb6 ("bpf: Make the bpf_prog_array_map more generic")

I guess this bug was reported by Fengguang as you have him in Cc ?

If that should be the case, then please also add a "Reported-by:" tag
for his bug report.

Code looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/