Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755314AbbHKIdS (ORCPT ); Tue, 11 Aug 2015 04:33:18 -0400 Received: from mail-yk0-f170.google.com ([209.85.160.170]:36286 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208AbbHKIdO (ORCPT ); Tue, 11 Aug 2015 04:33:14 -0400 MIME-Version: 1.0 In-Reply-To: <1438845731-17805-3-git-send-email-eddie.huang@mediatek.com> References: <1438845731-17805-1-git-send-email-eddie.huang@mediatek.com> <1438845731-17805-3-git-send-email-eddie.huang@mediatek.com> From: Daniel Kurtz Date: Tue, 11 Aug 2015 16:32:54 +0800 X-Google-Sender-Auth: h2pNL-Ba2H1QJjy07Pi7F-X3N9w Message-ID: Subject: Re: [PATCH v2 2/2] i2c: mediatek: Fixup i2c ack error interrupt handling To: Eddie Huang Cc: Wolfram Sang , srv_heupstream , Matthias Brugger , Liguo Zhang , Xudong Chen , Sascha Hauer , Linux I2C , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2378 Lines: 59 On Thu, Aug 6, 2015 at 3:22 PM, Eddie Huang wrote: > When occur i2c ack error, i2c controller generate two interrupts, > first is the ack error interrupt, then the complete interrupt. > i2c interrupt handler should keep the two interrupt value, and only > call complete() for the complete interrupt. > > Signed-off-by: Liguo Zhang > Signed-off-by: Eddie Huang Reviewed-by: Daniel Kurtz > --- > drivers/i2c/busses/i2c-mt65xx.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c > index e28ad4c..c02e6c0 100644 > --- a/drivers/i2c/busses/i2c-mt65xx.c > +++ b/drivers/i2c/busses/i2c-mt65xx.c > @@ -557,15 +557,22 @@ static irqreturn_t mtk_i2c_irq(int irqno, void *dev_id) > { > struct mtk_i2c *i2c = dev_id; > u16 restart_flag = 0; > + u16 intr_stat; > > if (i2c->dev_comp->auto_restart) > restart_flag = I2C_RS_TRANSFER; > > - i2c->irq_stat = readw(i2c->base + OFFSET_INTR_STAT); > - writew(restart_flag | I2C_HS_NACKERR | I2C_ACKERR > - | I2C_TRANSAC_COMP, i2c->base + OFFSET_INTR_STAT); > + intr_stat = readw(i2c->base + OFFSET_INTR_STAT); > + writew(intr_stat, i2c->base + OFFSET_INTR_STAT); > > - complete(&i2c->msg_complete); > + /* > + * when occurs ack error, i2c controller generate two interrupts > + * first is the ack error interrupt, then the complete interrupt > + * i2c->irq_stat need keep the two interrupt value. > + */ > + i2c->irq_stat |= intr_stat; > + if (i2c->irq_stat & (I2C_TRANSAC_COMP | restart_flag)) > + complete(&i2c->msg_complete); > > return IRQ_HANDLED; > } > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/