Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755377AbbHKIr2 (ORCPT ); Tue, 11 Aug 2015 04:47:28 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:1236 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753863AbbHKIrX (ORCPT ); Tue, 11 Aug 2015 04:47:23 -0400 X-IronPort-AV: E=Sophos;i="5.15,652,1432598400"; d="scan'208";a="293268909" Message-ID: <1439282834.9747.189.camel@citrix.com> Subject: Re: [PATCH v4] dtb: Create a common home for cross-architecture dtsi files. From: Ian Campbell To: Masahiro Yamada CC: Linux Kernel Mailing List , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , Liviu Dudau , Sudeep Holla , "Lorenzo Pieralisi" , Russell King , Catalin Marinas , "Will Deacon" , Kristina Martsenko , Kevin Hilman , , linux-arm-kernel , Linux Kbuild mailing list Date: Tue, 11 Aug 2015 09:47:14 +0100 In-Reply-To: References: <1438617993-1012-1-git-send-email-ian.campbell@citrix.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3251 Lines: 81 On Tue, 2015-08-11 at 13:00 +0900, Masahiro Yamada wrote: > Hi > > 2015-08-04 1:06 GMT+09:00 Ian Campbell : > > Commit 9ccd608070b6 ("arm64: dts: add device tree for ARM SMM-A53x2 on > > LogicTile Express 20MG") added a new dts file to arch/arm64 which > > included "../../../../arm/boot/dts/vexpress-v2m-rs1.dtsi", i.e. a > > .dtsi supplied by arch/arm. > > > > Unfortunately this causes some issues for the split device tree > > repository[0], since things get moved around there. In that context > > the new .dts ends up at src/arm64/arm/vexpress-v2f-1xv7-ca53x2.dts > > while the include is at src/arm/vexpress-v2m-rs1.dtsi. > > > > The sharing of the .dtsi is legitimate since the baseboard is the same > > for various vexpress systems whatever processor they use. > > > > Rather than using ../../ tricks to pickup .dtsi files from another > > arch this patch creates a new directory kernel/dts as a home for such > > cross-arch .dtsi files and arranges for it to be in the include path > > for both dtc and cpp. The dtsi file itself is moved into a vendor > > subdir in this case "arm" (the vendor, not the ARCH=). > > > Question: > If this patch is applied, which directory will be created in > device-tree-rebasing? > src/kernel/, src/common/, or something else? > Either will do, of course. Below is the patch against the device-tree-rebasing.git, I went (pretty much arbitrarily) with common at the top level. commit 0524b00e5bd7b98a2a9ef85c1f5f2a8d93bcbeb6 Author: Ian Campbell Date: Tue Jul 21 17:27:13 2015 +0100 Handle new kernel/dts subtree. Rewrite its contents to common/ and include in the CPP and DTC include paths. Signed-off-by: Ian Campbell diff --git a/Makefile b/Makefile index 5e8930c..b57107d 100644 --- a/Makefile +++ b/Makefile @@ -114,12 +114,13 @@ dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp) dtc_cpp_flags = -Wp,-MD,$(depfile).pre.tmp -nostdinc \ -Iinclude -I$(src) -Itestcase-data \ + -Icommon \ -undef -D__DTS__ quiet_cmd_dtc = DTC $@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \ $(DTC) -O dtb -o $@ -b 0 \ - -i $(src) $(DTC_FLAGS) \ + -i $(src) -i common $(DTC_FLAGS) \ -d $(depfile).dtc.tmp $(dtc-tmp) ; \ cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile) diff --git a/scripts/rewrite-paths.sed b/scripts/rewrite-paths.sed index b73fbce..5269769 100644 --- a/scripts/rewrite-paths.sed +++ b/scripts/rewrite-paths.sed @@ -33,6 +33,7 @@ s,\tarch/\([^/]*\)/boot/dts/\(.*\.h\)$,\tsrc/\1/\2,gp # Also rewrite the DTS include paths for dtc+cpp support s,\tarch/\([^/]*\)/include/dts/,\tsrc/\1/include/,gp s,\tinclude/dt-bindings/,\tinclude/dt-bindings/,gp +s,\tkernel/dts/,\tcommon/,gp # Rewrite the bindings subdirectory s,\tDocumentation/devicetree/bindings/,\tBindings/,gp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/