Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934055AbbHKJ2O (ORCPT ); Tue, 11 Aug 2015 05:28:14 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53726 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933700AbbHKJ2M (ORCPT ); Tue, 11 Aug 2015 05:28:12 -0400 Date: Tue, 11 Aug 2015 11:27:54 +0200 From: Peter Zijlstra To: Morten Rasmussen Cc: mingo@redhat.com, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, Dietmar Eggemann , yuyang.du@intel.com, mturquette@baylibre.com, rjw@rjwysocki.net, Juri Lelli , sgurrappadi@nvidia.com, pang.xunlei@zte.com.cn, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Russell King Subject: Re: [RFCv5 PATCH 01/46] arm: Frequency invariant scheduler load-tracking support Message-ID: <20150811092754.GS19282@twins.programming.kicks-ass.net> References: <1436293469-25707-1-git-send-email-morten.rasmussen@arm.com> <1436293469-25707-2-git-send-email-morten.rasmussen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436293469-25707-2-git-send-email-morten.rasmussen@arm.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 18 On Tue, Jul 07, 2015 at 07:23:44PM +0100, Morten Rasmussen wrote: > +static DEFINE_PER_CPU(atomic_long_t, cpu_max_freq); > +DEFINE_PER_CPU(atomic_long_t, cpu_freq_capacity); > + atomic_long_set(&per_cpu(cpu_freq_capacity, cpu), capacity); > + unsigned long max = atomic_long_read(&per_cpu(cpu_max_freq, cpu)); > + atomic_long_set(&per_cpu(cpu_max_freq, i), policy->max); > + unsigned long curr = atomic_long_read(&per_cpu(cpu_freq_capacity, cpu)); The use of atomic_long_t here is entirely pointless. In fact (and someone needs to go fix this), its worse than WRITE_ONCE()/READ_ONCE(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/