Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934514AbbHKJ4U (ORCPT ); Tue, 11 Aug 2015 05:56:20 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:47654 "EHLO e23smtp06.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934180AbbHKJ4P (ORCPT ); Tue, 11 Aug 2015 05:56:15 -0400 X-Helo: d23dlp01.au.ibm.com X-MailFrom: nikunj@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org From: Nikunj A Dadhania To: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au Cc: anton@samba.org, linux-kernel@vger.kernel.org, bharata@linux.vnet.ibm.com Subject: Re: [PATCH RESEND] powerpc/numa: initialize distance lookup table from drconf path In-Reply-To: <1435815541-11860-1-git-send-email-nikunj@linux.vnet.ibm.com> References: <1435815541-11860-1-git-send-email-nikunj@linux.vnet.ibm.com> User-Agent: Notmuch/0.17+27~gae47d61 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-redhat-linux-gnu) Date: Tue, 11 Aug 2015 15:25:17 +0530 Message-ID: <87si7q2lq2.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15081109-0021-0000-0000-000001B4D2B3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 51 Hi Michael, Nikunj A Dadhania writes: > In some situations, a NUMA guest that supports > ibm,dynamic-memory-reconfiguration node will end up having flat NUMA > distances between nodes. This is because of two problems in the > current code. > > 1) Different representations of associativity lists. > > There is an assumption about the associativity list in > initialize_distance_lookup_table(). Associativity list has two forms: > > a) [cpu,memory]@x/ibm,associativity has following > format: > > > b) ibm,dynamic-reconfiguration-memory/ibm,associativity-lookup-arrays > > > M = the number of associativity lists > N = the number of entries per associativity list > > Fix initialize_distance_lookup_table() so that it does not assume > "case a". And update the caller to skip the length field before > sending the associativity list. > > 2) Distance table not getting updated from drconf path. > > Node distance table will not get initialized in certain cases as > ibm,dynamic-reconfiguration-memory path does not initialize the > lookup table. > > Call initialize_distance_lookup_table() from drconf path with > appropriate associativity list. > > Reported-by: Bharata B Rao > Signed-off-by: Nikunj A Dadhania > Acked-by: Anton Blanchard Have you pulled this? Regards, Nikunj -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/