Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934279AbbHKJyy (ORCPT ); Tue, 11 Aug 2015 05:54:54 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:63838 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933788AbbHKJyw convert rfc822-to-8bit (ORCPT ); Tue, 11 Aug 2015 05:54:52 -0400 Message-ID: <55C9C691.8050407@arm.com> Date: Tue, 11 Aug 2015 10:55:29 +0100 From: Juri Lelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andrea Parri , Ingo Molnar , Peter Zijlstra CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] sched/deadline: fix comment in push_dl_tasks References: <1438782979-9057-1-git-send-email-parri.andrea@gmail.com> In-Reply-To: <1438782979-9057-1-git-send-email-parri.andrea@gmail.com> X-OriginalArrivalTime: 11 Aug 2015 09:54:48.0594 (UTC) FILETIME=[C27D4720:01D0D41B] X-MC-Unique: MNcOOwERTPWC_V2X8PMY6A-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 37 Hi Andrea, On 05/08/15 14:56, Andrea Parri wrote: > The comment is "misleading"; fix it by adapting a comment from > push_rt_tasks. > > Signed-off-by: Andrea Parri > --- > kernel/sched/deadline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 0a17af35..7c17001 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -1563,7 +1563,7 @@ out: > > static void push_dl_tasks(struct rq *rq) > { > - /* Terminates as it moves a -deadline task */ > + /* push_dl_task will return true if it moved a -deadline task */ > while (push_dl_task(rq)) > ; > } > Looks good, thanks! Best, - Juri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/