Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934265AbbHKKAz (ORCPT ); Tue, 11 Aug 2015 06:00:55 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:33142 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933882AbbHKKAx (ORCPT ); Tue, 11 Aug 2015 06:00:53 -0400 MIME-Version: 1.0 In-Reply-To: <1439285890-27329-26-git-send-email-j.anaszewski@samsung.com> References: <1439285890-27329-1-git-send-email-j.anaszewski@samsung.com> <1439285890-27329-26-git-send-email-j.anaszewski@samsung.com> From: Ricardo Ribalda Delgado Date: Tue, 11 Aug 2015 12:00:32 +0200 Message-ID: Subject: Re: [PATCH/RFC v5 25/57] leds: pca963x: Remove work queue To: Jacek Anaszewski Cc: Linux LED Subsystem , LKML , Bryan Wu , Richard Purdie , stsp@users.sourceforge.net, Andrew Lunn , Peter Meerwald Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 45 Hello Jacek Sorry for the late reply. On Tue, Aug 11, 2015 at 11:37 AM, Jacek Anaszewski wrote: > struct pca963x_led { > struct pca963x *chip; > - struct work_struct work; > enum led_brightness brightness; > struct led_classdev led_cdev; > int led_num; /* 0 .. 15 potentially */ > - enum pca963x_cmd cmd; > char name[32]; > u8 gdc; > u8 gfrq; > }; Maybe you want to remove also brightness, gdc and gfrq and pass them as arguments to the functions. > -static void pca963x_blink_work(struct pca963x_led *pca963x) > +static void pca963x_blink(struct pca963x_led *pca963x) something like: blink(pca963x, gdc, gfrq) Big disclaimer: i havent tested it on real hardware. Maybe next week I can get hold of a board with a pca chip. BTW: great thing that the work queue is implemented in the core :) Cheers! -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/