Message-ID: <55C9D101.8020004@arm.com>
Date: Tue, 11 Aug 2015 11:40:01 +0100
From: Juri Lelli <juri.lelli@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Andrea Parri <parri.andrea@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl
References: <1438782979-9057-1-git-send-email-parri.andrea@gmail.com> <1438782979-9057-2-git-send-email-parri.andrea@gmail.com>
In-Reply-To: <1438782979-9057-2-git-send-email-parri.andrea@gmail.com>
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1112
Lines: 37

Hi,

On 05/08/15 14:56, Andrea Parri wrote:
> The flag "dl_boosted" is set by comparing *absolute* deadlines
> (c.f., rt_mutex_setprio).
> 
> Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> ---
>  kernel/sched/deadline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 7c17001..be2ca5e 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
>  
>  	/*
>  	 * Use the scheduling parameters of the top pi-waiter
> -	 * task if we have one and its (relative) deadline is
> +	 * task if we have one and its (absolute) deadline is
>  	 * smaller than our one... OTW we keep our runtime and
>  	 * deadline.
>  	 */
> 

Right, thanks for spotting it.

Best,

- Juri

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/