Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934313AbbHKMD2 (ORCPT ); Tue, 11 Aug 2015 08:03:28 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:48257 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934277AbbHKMDZ (ORCPT ); Tue, 11 Aug 2015 08:03:25 -0400 Message-ID: <55C9E47D.4020606@st.com> Date: Tue, 11 Aug 2015 14:03:09 +0200 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Lee Jones , Michael Turquette , "linux-kernel@vger.kernel.org" , , Stephen Boyd , Maxime Ripard , Sascha Hauer Subject: Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag References: <1438974570-20812-1-git-send-email-mturquette@baylibre.com> <1438974570-20812-4-git-send-email-mturquette@baylibre.com> <20150810144811.GN3249@x1> <20150810185516.2416.32293@quantum> <20150811084329.GA13374@x1> <55C9C82F.6060401@st.com> <55C9DE57.2090105@st.com> <55C9DF7B.4040308@st.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.21.241] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-11_05:2015-08-11,2015-08-11,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1537 Lines: 39 On 08/11/2015 01:49 PM, Geert Uytterhoeven wrote: > Hi Maxime, > > On Tue, Aug 11, 2015 at 1:41 PM, Maxime Coquelin wrote: >> On 08/11/2015 01:36 PM, Maxime Coquelin wrote: >>> On 08/11/2015 12:11 PM, Geert Uytterhoeven wrote: >>>> On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin >>>> wrote: >>>>> How can we pass CLK_ENABLE_HAND_OFF flag to a specific clock on STi >>>>> platform? >>>> Add the flag to the relevant clocks in the C code, e.g. in >>>> clk_register_flexgen(): >>>> >>>> if (!strcmp(name, "clk-icn-cpu")) >>>> init.flags |= CLK_ENABLE_HAND_OFF; >> The main problem I see with this proposal is that clk_register_flexgen() is >> called for several SoCs (STiH407/410/418...). >> Each of these SoCs have this clock, but maybe STiH407 will need the flag, >> but not STiH410 and STiH418. >> So I think the best place to set this information is in DT, where the >> differentiation is made between the SoCs. > If (of_machine_is_compatible("st,stih410")) ... > It works, but is it really what we want? Each time we will add a new soc, we will have to patch this SoC agnostic function? With the number of SoCs and the number of clocks, it will be a nightmare to maintain and debug, no? Regards, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/