Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934369AbbHKMh5 (ORCPT ); Tue, 11 Aug 2015 08:37:57 -0400 Received: from mail-yk0-f174.google.com ([209.85.160.174]:32790 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934070AbbHKMh4 (ORCPT ); Tue, 11 Aug 2015 08:37:56 -0400 MIME-Version: 1.0 In-Reply-To: <1438931991-17044-4-git-send-email-leilk.liu@mediatek.com> References: <1438931991-17044-1-git-send-email-leilk.liu@mediatek.com> <1438931991-17044-4-git-send-email-leilk.liu@mediatek.com> From: Daniel Kurtz Date: Tue, 11 Aug 2015 20:37:36 +0800 X-Google-Sender-Auth: XBj9ca22rZFhtKrCrI4-gsv8Jig Message-ID: Subject: Re: [PATCH v5 3/3] arm64: dts: Add spi bus dts To: Leilk Liu Cc: Mark Brown , Mark Rutland , Matthias Brugger , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3034 Lines: 70 On Fri, Aug 7, 2015 at 3:19 PM, Leilk Liu wrote: > This patch adds MT8173 spi bus controllers into device tree. > > Signed-off-by: Leilk Liu > --- > Change in this patch: > 1. "pad-select" is a vendor property, so change it to "mediatek,pad-select". > 2. modify the property of clocks and clock-names. > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index d18ee42..066bd6a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -220,6 +220,15 @@ > bias-disable; > }; > }; > + > + spi_pins_a: spi0 { > + pins_spi { > + pinmux = , > + , > + , > + ; > + }; > + }; > }; > > scpsys: scpsys@10006000 { > @@ -365,6 +374,20 @@ > status = "disabled"; > }; > > + spi: spi@1100a000 { > + compatible = "mediatek,mt8173-spi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0 0x1100a000 0 0x1000>; > + interrupts = ; > + clocks = <&topckgen CLK_TOP_SPI_SEL>, <&topckgen CLK_TOP_SYSPLL3_D2>; > + clock-names = "spi-clk", "parent-clk"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spi_pins_a>; > + mediatek,pad-select = <0>; The pinctl and pad-select fields are board specific. Please move to mt8173-evb.dtsi, along with status = "okay"; > + status = "disabled"; > + }; > + > i2c3: i2c3@11010000 { > compatible = "mediatek,mt8173-i2c"; > reg = <0 0x11010000 0 0x70>, > -- > 1.8.1.1.dirty > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/