MIME-Version: 1.0
In-Reply-To: <20150810210318.GA10379@kroah.com>
References: <1439187861-3864-1-git-send-email-mike.rapoport@gmail.com>
	<20150810153835.GC13461@kroah.com>
	<CABpLfogMDbgVXVp8PGHjQ_qG-j4Q1TC-aKjGd5-D6wE1amCEXA@mail.gmail.com>
	<20150810210318.GA10379@kroah.com>
Date: Tue, 11 Aug 2015 16:09:28 +0300
Message-ID: <CABpLfogi+pqcT0GTuYNCqZvKABC_Qk2hzJGAUXcEhn08uJajbg@mail.gmail.com>
Subject: Re: [PATCH 0/6] staging: android: allow building some drivers as a module
From: Mike Rapoport <mike.rapoport@gmail.com>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: Brian Swetland <swetland@google.com>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1195
Lines: 37

On Tue, Aug 11, 2015 at 12:03 AM, Greg Kroah-Hartman <greg@kroah.com> wrote:
> On Mon, Aug 10, 2015 at 11:10:37PM +0300, Mike Rapoport wrote:
>> On Mon, Aug 10, 2015 at 6:38 PM, Greg Kroah-Hartman <greg@kroah.com> wrote:
>> > On Mon, Aug 10, 2015 at 09:24:15AM +0300, Mike Rapoport wrote:
>> >> Hi,
>> >>
>> >> These patches enable building of timed_gpio, sync* and ashmem as a module
>> >
>> > Why do you want to do this?
>>
>> Apparently I've misread "- make sure things build as modules properly"
>> line in drivers/staging/android/TODO...
>> My bad.
>
> Nope, not your fault, I forgot about that.  We should remove that TODO
> item, as it doesn't make sense for these "non-discoverable" modules to
> be built as a module.
>
> Care to make a patch for that?

I'll make, no problem.
What about other irrelevant parts of that TODO, like, e.g.,  dead
Brian Sweetland address? Remove them as well?
> thanks,
>
> greg k-h


-- 
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/