Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965266AbbHKOUh (ORCPT ); Tue, 11 Aug 2015 10:20:37 -0400 Received: from foss.arm.com ([217.140.101.70]:53817 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964890AbbHKOUe (ORCPT ); Tue, 11 Aug 2015 10:20:34 -0400 From: Javi Merino To: linux-kernel@vger.kernel.org Cc: Javi Merino , Joe Perches , Petr Mladek , Andy Whitcroft , Andrew Morton Subject: [PATCH] checkpatch: check Signed-off-by: lines for patches coming from stdin Date: Tue, 11 Aug 2015 15:20:14 +0100 Message-Id: <1439302814-5750-1-git-send-email-javi.merino@arm.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1782 Lines: 47 Commit 34d8815f9512 ("checkpatch: add --showfile to allow input via pipe to show filenames") disabled the ability to check for Signed-off-by lines in patches that are fed to scripts/checkpatch.pl from stdin. This makes things like: git rebase --interactive --exec 'git format-patch --stdout -1 | scripts/checkpatch.pl --strict -' not complain about patches without a Signed-off-by. While commit 34d8815f9512 ("checkpatch: add --showfile to allow input via pipe to show filenames") is meant to work with the output of git diff, this should be achieved by explicitly passing --no-signoff to checkpatch.pl: git diff | ./scripts/checkpatch --no-signoff - Fixes: 34d8815f9512 ("checkpatch: add --showfile to allow input via pipe to show filenames") Cc: Joe Perches Cc: Petr Mladek Cc: Andy Whitcroft Cc: Andrew Morton Signed-off-by: Javi Merino --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d5c8e9a3a73c..984e7ddfd7e3 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5684,7 +5684,7 @@ sub process { ERROR("NOT_UNIFIED_DIFF", "Does not appear to be a unified-diff format patch\n"); } - if ($is_patch && $filename ne '-' && $chk_signoff && $signoff == 0) { + if ($is_patch && $chk_signoff && $signoff == 0) { ERROR("MISSING_SIGN_OFF", "Missing Signed-off-by: line(s)\n"); } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/