Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755359AbbHKPb7 (ORCPT ); Tue, 11 Aug 2015 11:31:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:41645 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbbHKPb5 (ORCPT ); Tue, 11 Aug 2015 11:31:57 -0400 Date: Tue, 11 Aug 2015 16:31:50 +0100 From: Lee Jones To: Daniel Lezcano Cc: mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, Viresh Kumar , Stephen Warren , "moderated list:BROADCOM BCM2835..." Subject: Re: [PATCH 03/74] clockevents/drivers/bcm2835: Migrate to new 'set-state' interface Message-ID: <20150811153150.GP18282@x1> References: <55C87382.4070309@linaro.org> <1439200352-26767-1-git-send-email-daniel.lezcano@linaro.org> <1439200352-26767-3-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439200352-26767-3-git-send-email-daniel.lezcano@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2378 Lines: 67 On Mon, 10 Aug 2015, Daniel Lezcano wrote: > From: Viresh Kumar > > Migrate bcm2835 driver to the new 'set-state' interface provided by > the clockevents core, the earlier 'set-mode' interface is marked > obsolete now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. > > We weren't doing anything in the ->set_mode() callback. So, this patch > doesn't provide any set-state callbacks. > > Acked-by: Daniel Lezcano > Tested-by: Stephen Warren > Cc: Stephen Warren > Cc: Lee Jones > Signed-off-by: Viresh Kumar > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/bcm2835_timer.c | 16 ---------------- > 1 file changed, 16 deletions(-) Looks fine. Acked-by: Lee Jones > diff --git a/drivers/clocksource/bcm2835_timer.c b/drivers/clocksource/bcm2835_timer.c > index 26ed331..6f28229 100644 > --- a/drivers/clocksource/bcm2835_timer.c > +++ b/drivers/clocksource/bcm2835_timer.c > @@ -54,21 +54,6 @@ static u64 notrace bcm2835_sched_read(void) > return readl_relaxed(system_clock); > } > > -static void bcm2835_time_set_mode(enum clock_event_mode mode, > - struct clock_event_device *evt_dev) > -{ > - switch (mode) { > - case CLOCK_EVT_MODE_ONESHOT: > - case CLOCK_EVT_MODE_UNUSED: > - case CLOCK_EVT_MODE_SHUTDOWN: > - case CLOCK_EVT_MODE_RESUME: > - break; > - default: > - WARN(1, "%s: unhandled event mode %d\n", __func__, mode); > - break; > - } > -} > - > static int bcm2835_time_set_next_event(unsigned long event, > struct clock_event_device *evt_dev) > { > @@ -129,7 +114,6 @@ static void __init bcm2835_timer_init(struct device_node *node) > timer->evt.name = node->name; > timer->evt.rating = 300; > timer->evt.features = CLOCK_EVT_FEAT_ONESHOT; > - timer->evt.set_mode = bcm2835_time_set_mode; > timer->evt.set_next_event = bcm2835_time_set_next_event; > timer->evt.cpumask = cpumask_of(0); > timer->act.name = node->name; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/