Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965308AbbHKPyh (ORCPT ); Tue, 11 Aug 2015 11:54:37 -0400 Received: from down.free-electrons.com ([37.187.137.238]:36973 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965076AbbHKPyg (ORCPT ); Tue, 11 Aug 2015 11:54:36 -0400 Date: Tue, 11 Aug 2015 17:54:34 +0200 From: Alexandre Belloni To: Viresh Kumar Cc: akpm@linux-foundation.org, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, "moderated list:BLACKFIN RTC DRIVER" , Alessandro Zummo , Hans Ulli Kroll , "moderated list:ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" Subject: Re: [PATCH 9/15 V2] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) Message-ID: <20150811155434.GT3411@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 32 On 31/07/2015 at 16:23:43 +0530, Viresh Kumar wrote : > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > is no need to do that again from its callers. Drop it. > > gemini driver was using likely() for a failure case while the rtc driver > is getting registered. That looks wrong and it should really be > unlikely. But because we are killing all the unlikely() flags, lets kill > that too. > > Signed-off-by: Viresh Kumar > --- > V1->V2: > - Removed the likely() part from gemini driver and the changelog wasn't > updated to match that. Fixed the changelog now. > > drivers/rtc/interface.c | 2 +- > drivers/rtc/rtc-bfin.c | 2 +- > drivers/rtc/rtc-gemini.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/