Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965362AbbHKQQV (ORCPT ); Tue, 11 Aug 2015 12:16:21 -0400 Received: from sauhun.de ([89.238.76.85]:47566 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755206AbbHKQQT (ORCPT ); Tue, 11 Aug 2015 12:16:19 -0400 Date: Tue, 11 Aug 2015 18:16:10 +0200 From: Wolfram Sang To: York Sun Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Paul Bolle , Peter Korsgaard , Alexander Sverdlin Subject: Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg Message-ID: <20150811161610.GA1523@katana> References: <1434657458-16553-1-git-send-email-yorksun@freescale.com> <20150811153916.GD1525@katana> <55CA1ADF.200@freescale.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Content-Disposition: inline In-Reply-To: <55CA1ADF.200@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2091 Lines: 58 --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >> + if (of_find_property(np, "little-endian", NULL)) { > >=20 > > You should check for a "big-endian" property as well, no? >=20 > I use the little-endian as an option to indicate the nature of litten-end= ian > register. It is default to big-endian if this property doesn't exist. I p= refer > this way unless you strongly suggest to add both and throw out an error if > neither exists. I'd think that "little-endian" or "big-endian" force a setting. If none is present, we shall take the CPU endianess. Or am I overlooking something? Oh, and I forgot the biggest issue: I get build errors, because __LITTLE_ENDIAN__ should be __LITTLE_ENDIAN. Is this a recent change or why did it work for you? Thanks for the quick response, Wolfram --FCuugMFkClbJLl1L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVyh/KAAoJEBQN5MwUoCm2qSwQAJsW6hioc2JzPuWOM6sQcMyh tAi8D8vqgm3fuchhmwZv0ktgYUE6b/duPEt9+PnGowEBx75knlKp0n/Jf40YiGtO /YwpWb5MCU3p80QIi5PJWyHbMJRY2eEy0PgmEuGWxaB7+jprXcHtXWXvuPdZngjZ 2LBg1yWkXPgMR1kx2mSAtuEFusskRhJ/D9uEZIHGFd3dR2IycHXNd+T5bT4khfPD LTQlPe9uDB2uJZTfEDO8NOh1OAovaAC5X8W+E0Vy0DtjthQibLKtooZXE8RNtGXI 94HCNzc+yGqWb6HqFY9JcXfp0JrQ/c3ouv6l65eMPy3MpZIz4sjeHKJDc3p4i6ge rkRrrXqXagUcpG8IGEXE1nuWY/cs5s5yViAHhHYG3+tcRpC8dGteJrKG03P/paQS drt5xLrClpZnm7oqIEg/nUw2qYVmjOqwgtEvfbWWapvskZOaOVpQvnWJo4jEks8t fOg9QzjnHJ7YZfQlKPUOyrwkGt7H4+5FF8eo2Q5SV35spYe+UuoxVtBgXspuHOK3 sAHv40va59pweoLq59csvfAPqj+Mah7oxRbG1+UEMeYkcWuajXsBPhjKamfNt6bt 62Gaf7fYkpAzyisHxVZygSXbEHMbSFQjPkblyFvv0s9AyQgooTZxVdqbgDuyV/fc coNIu7Nh0utpC0PgcciV =3SEN -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/