Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965322AbbHKQry (ORCPT <rfc822;w@1wt.eu>);
	Tue, 11 Aug 2015 12:47:54 -0400
Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:36177 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752728AbbHKQrx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Aug 2015 12:47:53 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:967:973:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:9025:9388:9392:10004:10400:10848:11232:11658:11855:11914:12517:12519:12740:13069:13095:13161:13229:13255:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: tree42_6185f18516f5a
X-Filterd-Recvd-Size: 1684
Message-ID: <1439311669.3244.14.camel@perches.com>
Subject: Re: [PATCH] checkpatch: check Signed-off-by: lines for patches
 coming from stdin
From: Joe Perches <joe@perches.com>
To: Javi Merino <javi.merino@arm.com>
Cc: linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.cz>,
        Andy Whitcroft <apw@canonical.com>,
        Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 11 Aug 2015 09:47:49 -0700
In-Reply-To: <1439302814-5750-1-git-send-email-javi.merino@arm.com>
References: <1439302814-5750-1-git-send-email-javi.merino@arm.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1003
Lines: 24

On Tue, 2015-08-11 at 15:20 +0100, Javi Merino wrote:
> Commit 34d8815f9512 ("checkpatch: add --showfile to allow input via pipe
> to show filenames") disabled the ability to check for Signed-off-by
> lines in patches that are fed to scripts/checkpatch.pl from stdin.  This
> makes things like:
> 
> git rebase --interactive --exec 'git format-patch --stdout -1 | scripts/checkpatch.pl --strict -'

This is akin to running checkpatch on patches to the stable tree.
Generally unnecessary.

I think patches should never be committed without a sign-off so
the concept of using checkpatch when rebasing is fundamentally
odd, but <shrug>, different workflows for different folks.

You should add a "Reference: http://xkcd.com/1172/" line to the
commit message.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/