Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753523AbbHKRZZ (ORCPT ); Tue, 11 Aug 2015 13:25:25 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:50362 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbbHKRZY (ORCPT ); Tue, 11 Aug 2015 13:25:24 -0400 Date: Tue, 11 Aug 2015 10:25:21 -0700 (PDT) Message-Id: <20150811.102521.448694660627631235.davem@davemloft.net> To: jmaxwell37@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jmaxwell@redhat.com Subject: Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp() From: David Miller In-Reply-To: References: <1439256746-7953-1-git-send-email-jmaxwell37@gmail.com> <20150810.212256.1658635789817625453.davem@davemloft.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 11 Aug 2015 10:25:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 17 From: Jonathan Maxwell Date: Tue, 11 Aug 2015 15:53:18 +1000 >> What if the carrier check passes, and then the chip reset starts on >> another cpu? You'll have the same problem. > > Okay, let me see if I can come up with a better way to mitigate this. I personally think that drivers need to synchronize such things internally. They are the only entity which knows when it's "OK" to do whatever the netpoll method does, and they are also the only entity which can properly synchronize such checks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/