Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753220AbbHKSK0 (ORCPT ); Tue, 11 Aug 2015 14:10:26 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:59521 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752706AbbHKSKV (ORCPT ); Tue, 11 Aug 2015 14:10:21 -0400 X-Sasl-enc: JGfJBcVmZ8QVuO4mjBuD2RTHNbOOFd4Exyi1QmNDboot 1439316618 Date: Tue, 11 Aug 2015 11:10:17 -0700 From: Greg Kroah-Hartman To: Mike Rapoport Cc: Brian Swetland , LKML Subject: Re: [PATCH 0/6] staging: android: allow building some drivers as a module Message-ID: <20150811181017.GA29765@kroah.com> References: <1439187861-3864-1-git-send-email-mike.rapoport@gmail.com> <20150810153835.GC13461@kroah.com> <20150810210318.GA10379@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 33 On Tue, Aug 11, 2015 at 04:09:28PM +0300, Mike Rapoport wrote: > On Tue, Aug 11, 2015 at 12:03 AM, Greg Kroah-Hartman wrote: > > On Mon, Aug 10, 2015 at 11:10:37PM +0300, Mike Rapoport wrote: > >> On Mon, Aug 10, 2015 at 6:38 PM, Greg Kroah-Hartman wrote: > >> > On Mon, Aug 10, 2015 at 09:24:15AM +0300, Mike Rapoport wrote: > >> >> Hi, > >> >> > >> >> These patches enable building of timed_gpio, sync* and ashmem as a module > >> > > >> > Why do you want to do this? > >> > >> Apparently I've misread "- make sure things build as modules properly" > >> line in drivers/staging/android/TODO... > >> My bad. > > > > Nope, not your fault, I forgot about that. We should remove that TODO > > item, as it doesn't make sense for these "non-discoverable" modules to > > be built as a module. > > > > Care to make a patch for that? > > I'll make, no problem. > What about other irrelevant parts of that TODO, like, e.g., dead > Brian Sweetland address? Remove them as well? Yes, please remove that as well, good catch. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/