Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932249AbbHKSwX (ORCPT ); Tue, 11 Aug 2015 14:52:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:5000 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433AbbHKSwV (ORCPT ); Tue, 11 Aug 2015 14:52:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,655,1432623600"; d="scan'208";a="623561234" From: "Luck, Tony" To: Borislav Petkov , Xie XiuQi CC: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "zhangliguang@huawei.com" Subject: RE: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode Thread-Topic: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode Thread-Index: AQHQ1B6ZbaGQ/v+pbUa8+y70OxST2p4HViiA///NoOA= Date: Tue, 11 Aug 2015 18:52:00 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F32ADCEE3@ORSMSX114.amr.corp.intel.com> References: <1439287777-8270-1-git-send-email-xiexiuqi@huawei.com> <20150811144637.GA5573@nazgul.tnic> In-Reply-To: <20150811144637.GA5573@nazgul.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7BIqRks012869 Content-Length: 592 Lines: 11 > Well, ok, but do it differently, please: rename > cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which > turns them on and off. Unless Tony has a better suggestion... I like the boolean argument ... but not the "switch_banks" name. It sounds more like we are juggling between banks, rather than setting a switch/flag in a bank. How does "cmci_storm_set_cmci(bool on)" sound? Too many "cmci" in one name? -Tony ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?