Message-ID: <55CA5567.9010002@caviumnetworks.com>
Date: Tue, 11 Aug 2015 13:04:55 -0700
From: David Daney <ddaney@caviumnetworks.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: <ddaney.cavm@gmail.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mips@linux-mips.org>,
        <rrichter@cavium.com>, <tomasz.nowicki@linaro.org>,
        <sgoutham@cavium.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-acpi@vger.kernel.org>, <mark.rutland@arm.com>,
        <rafael@kernel.org>, <david.daney@cavium.com>
Subject: Re: [PATCH v2 0/2] net: thunder: Add ACPI support.
References: <1439254717-2875-1-git-send-email-ddaney.cavm@gmail.com> <20150811.114908.1384923604512568161.davem@davemloft.net>
In-Reply-To: <20150811.114908.1384923604512568161.davem@davemloft.net>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2015 20:04:59.8326 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1722
X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1126;2:VNUoCrMUTNNhyEvmj9rf6KKily7u2OZ9c+oapXWj2tSwJT2zjDNyXPHOsLN4CFNfmAh3tGvTcgoZo7uTL0H0fnYrewJuw5w4cZL6aVHay1LSBiHILIhLaKNKCD2LHaS0+6KVqYoR6p401xpcEAcCOzHk0hEobfQiS6n+a8P8Jrc=;3:M65WEeQnUeBCIgLiV4hyV2i/2Ic6HsuufmGcfHmRL+3VLN3r+xgdJ1zitCQ4uZ30aS8R7ybi3fuRBr54GwC8uW4m6PLivXbOZYR9IAtGMVucY9G1k9Cc/2ftP0bv4NhCCuu4dnbsTVdvb4ffo0bD6A==;25:NClsV2tVvurV3CK9pJItpn9HrM3rZetgpicx9Urnk3M2eOZkgoo3LNl/ONjAs3x0NiIdZLVDALypovq8ptFE7xE09cLQA2WAXBl6Vvz1srAEenF9Gh6fh0t07n5QTw/0sfsjsCG4EOyosj/XFM2GNvFLPfzygnSrXlX8bxhT7uQEifg98psScWal3D7WmcvdTdg6xU+mjT5vo9xMBf8E5ce0MmB7Xfgv8opHriR+PaJWYRVqKbI6TN0W4dVw/uZ5RkBDWRX50lnXMH62Qca65A==;23:319wVtGZtpDcdmOGFFxDKpElKL+TPNJyXsLT2IGzM66Nvj5AhX6KrcXghLQZch8FbGc/wg0ExlIJcCu9kPyAvY/nxIMQMXVnivr9Tpj1qPJnlSOrDdwepkqr0YvNze/C/cALVmAXMVKCynpk1V9p4Y4rQ2RZAC51Njui57ty3UCqRLhvul+lwAdi5r15GxmABSZoc4/uQEOeqOngy9Py3ucBmxG02KZ9KRbBCpVU8YDcBJVHxTCRfnCmB9O5VZnO
X-OriginatorOrg: caviumnetworks.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1208
Lines: 36

On 08/11/2015 11:49 AM, David Miller wrote:
> From: David Daney <ddaney.cavm@gmail.com>
> Date: Mon, 10 Aug 2015 17:58:35 -0700
>
>> Change from v1:  Drop PHY binding part, use fwnode_property* APIs.
>>
>> The first patch (1/2) rearranges the existing code a little with no
>> functional change to get ready for the second.  The second (2/2) does
>> the actual work of adding support to extract the needed information
>> from the ACPI tables.
>
> Series applied.

Thank you very much.

>
> In the future it might be better structured to try and get the OF
> node, and if that fails then try and use the ACPI method to obtain
> these values.

Our current approach, as you can see in the patch, is the opposite.  If 
ACPI is being used, prefer that over the OF device tree.

You seem to be recommending precedence for OF.  It should be consistent 
across all drivers/sub-systems, so do you really think that OF before 
ACPI is the way to go?

Thanks,
David Daney


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/