Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933112AbbHKUN4 (ORCPT ); Tue, 11 Aug 2015 16:13:56 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:50181 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbbHKUNy (ORCPT ); Tue, 11 Aug 2015 16:13:54 -0400 Message-ID: <1439324020.10857.61.camel@decadent.org.uk> Subject: Re: [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect. From: Ben Hutchings To: Richard Stearn Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, Ralf Baechle , "David S. Miller" Date: Tue, 11 Aug 2015 22:13:40 +0200 In-Reply-To: <55C8906F.2040507@rns-stearn.demon.co.uk> References: <55C8906F.2040507@rns-stearn.demon.co.uk> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-k6iDwbQt52mcWPw82kcM" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 141.70.72.77 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2759 Lines: 80 --=-k6iDwbQt52mcWPw82kcM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-08-10 at 12:52 +0100, Richard Stearn wrote: > Ben Hutchings wrote: > > 3.2.71-rc1 review patch. If anyone has any objections, please let me k= now. > >=20 > > ------------------ > >=20 > > From: Richard Stearn > >=20 > > commit da278622bf04f8ddb14519a2b8214e108ef26101 upstream. > >=20 > > This may result in a kernel panic. The bug has always existed but > > somehow we've run out of luck now and it bites. > >=20 > > Signed-off-by: Richard Stearn > > Signed-off-by: Ralf Baechle > > Signed-off-by: David S. Miller > > Signed-off-by: Ben Hutchings > > --- > > net/ax25/ax25_subr.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > --- a/net/ax25/ax25_subr.c > > +++ b/net/ax25/ax25_subr.c > > @@ -265,6 +265,7 @@ void ax25_disconnect(ax25_cb *ax25, int > > { > > > > > > ax25_clear_queues(ax25); > > =20 > > +> > > > ax25_stop_heartbeat(ax25); > > > > > > ax25_stop_t1timer(ax25); > > > > > > ax25_stop_t2timer(ax25); > > > > > > ax25_stop_t3timer(ax25); >=20 > This patch should _not_ be applied. > Breaks other parts of the driver. > Investigations on-going. OK, I'll drop it for now. Ben. --=20 Ben Hutchings Theory and practice are closer in theory than in practice. - John Levine, moderator of comp.compilers --=-k6iDwbQt52mcWPw82kcM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVcpXdOe/yOyVhhEJAQqVWA/+O6IinCwD5XLEbDZ+KPw5Fz2cd9jvAmwE dhbnAjrbfW0O9fkdrhw2Rjxt67ytmwDnMxzIzJXws6NUDvDHOD8H4SrBqz3sp/Cy +uWzIJUs5c+NYuZV4DE3SI2UyM+ruj9eTbrWFk6J86ufd3pRAIWcHsFrRzpmGaEu NcoiY+DEauuPffSDCgZFnNGobOpEgwMHcXgDnVChpx6KfoRTDtRGlhUSHm+Oa0AV nLAggK3XaFO2tLvXyXDwkkElKTVRH7Pyhfmne9A50sfGDaGcPu5S0Ok7X46REu0Y Je0dft0f72lEiObvJjcwe7TXFleDCTywg9pksSmY4TLcjU7qxoV0l+7ZPzfEAqnV rR8VnDLZMjFjhIHaDLw0h+0BFzwqc3YW7B8UXMLLWzlPUMrp633Qr1FCPBYOhT8T y47yFIABLsJwP+Zmmx4Pf22J9+HMBmMPr/c81onIKevh9NnvNjkAXUAjfN8A95PH uJgJMG2VCvnVhg/9JEyn2Jv7T+6au2LEW1An5HZufuI1dtGLsdKm8fJxqfY24I+g kAMknnOqSbsg0+m/ezN6iRiL4O3TKRq3Ab5tt34/NT4/eHZyCdm5IvQZNTTMADh6 I9MDnh9fYAGN/MMe57BdndaWvzGn+J3Moh6nfflet241xebdzHFg7AlSCuiceEo9 /G70Wzz2IZo= =vYJO -----END PGP SIGNATURE----- --=-k6iDwbQt52mcWPw82kcM-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/